Uh oh!
There was an error while loading. Please reload this page.
add more pat2021 tests - #84185
Merged
Merged
Conversation
nikomatsakis
requested changes
Apr 14, 2021
nikomatsakis
left a comment
Contributor
There was a problem hiding this comment.
One thing I would like is a test macro-pat-pattern-followed-by-or-in-2021.rs that uses // edition: 2021 and which has $x:pat | and shows that we get an error (and probably one without the edition that does not...)
0xPoe
commented
Apr 14, 2021
MemberAuthor
@nikomatsakis How about now? |
nikomatsakis
approved these changes
Apr 14, 2021
nikomatsakis
commented
Apr 14, 2021
Contributor
@bors r+ rollup |
bors
commented
Apr 14, 2021
Collaborator
📌 Commit eb944c1 has been approved by |
0xPoe
commented
Apr 14, 2021
MemberAuthor
@nikomatsakis Thanks for your review. |
Dylan-DPC-zz pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Apr 14, 2021
…omatsakis add more pat2021 tests closerust-lang#84138 r? `@nikomatsakis`
Dylan-DPC-zz pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Apr 14, 2021
…omatsakis add more pat2021 tests closerust-lang#84138 r? ``@nikomatsakis``
This was referenced Apr 14, 2021
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 14, 2021
Rollup of 7 pull requests Successful merges: - rust-lang#82492 (Move `std::sys_common::alloc` to new module `std::sys::common`) - rust-lang#84177 (Fix join_paths error display.) - rust-lang#84185 (add more pat2021 tests) - rust-lang#84191 (Update books) - rust-lang#84192 (Fix typos in rustc_codegen_ssa/src/back/write.rs.) - rust-lang#84196 (:arrow_up: rust-analyzer) - rust-lang#84201 (rustdoc: Note that forbidding anchors in links to primitives is a bug) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close#84138
r? @nikomatsakis