Uh oh!
There was an error while loading. Please reload this page.
rustdoc: get rid of unused path printing code - #84246
Merged
Merged
Conversation
The code for printing a raw path is only used in utils.rs, which only prints the alternative (non-HTML) format. Path has a function that does the same thing without HTML support, so use that instead.
rust-highfive
commented
Apr 16, 2021
Contributor
r? @jyn514 (rust-highfive has picked a reviewer for you, use r? to override) |
notriddle
commented
Apr 16, 2021
ContributorAuthor
This is another change factored out of #83237. The root cause behind this PR, in common with some other ones, is that you need access to more information to do HTML printing than you need to do non-HTML printing. |
jyn514
commented
Apr 16, 2021
Member
r=me with CI passing (make sure to use @bors delegate=notriddle |
bors
commented
Apr 16, 2021
Collaborator
✌️ @notriddle can now approve this pull request |
notriddle
commented
Apr 16, 2021
ContributorAuthor
@bors r=jyn514 |
bors
commented
Apr 16, 2021
Collaborator
📌 Commit 6109cee has been approved by |
jyn514 pushed a commit
to jyn514/rust
that referenced
this pull request
Apr 16, 2021
…anup, r=jyn514 rustdoc: get rid of unused path printing code The code for printing a raw path is only used in utils.rs, which only prints the alternative (non-HTML) format. Path has a function that does the same thing without HTML support, so use that instead.
Dylan-DPC-zz pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Apr 17, 2021
…anup, r=jyn514 rustdoc: get rid of unused path printing code The code for printing a raw path is only used in utils.rs, which only prints the alternative (non-HTML) format. Path has a function that does the same thing without HTML support, so use that instead.
bors
commented
Apr 17, 2021
Collaborator
bors
commented
Apr 17, 2021
Collaborator
☀️ Test successful - checks-actions |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code for printing a raw path is only used in utils.rs, which only prints the alternative (non-HTML) format. Path has
a function that does the same thing without HTML support, so use that instead.