Skip to content

Error when compiletest is passed duplicate revisions - #84261

Merged
bors merged 1 commit into
rust-lang:masterfrom
Aaron1011:error-dup-revisions
Apr 17, 2021
Merged

Error when compiletest is passed duplicate revisions#84261
bors merged 1 commit into
rust-lang:masterfrom
Aaron1011:error-dup-revisions

Conversation

@Aaron1011

Copy link
Copy Markdown
Contributor

Currently, we allow the user to write things like
'// revisions: rpass1 rpass1', which will not test what they were
intending to test.

Currently, we allow the user to write things like
'// revisions: rpass1 rpass1', which will not test what they were
intending to test.
@rust-highfive

Copy link
Copy Markdown
Contributor

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 16, 2021
@Mark-Simulacrum

Copy link
Copy Markdown
Member

@bors r+

@bors

bors commented Apr 16, 2021

Copy link
Copy Markdown
Collaborator

📌 Commit 4cfc7b3 has been approved by Mark-Simulacrum

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 16, 2021
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Apr 17, 2021
…rk-Simulacrum
Error when compiletest is passed duplicate revisions
Currently, we allow the user to write things like
'// revisions: rpass1 rpass1', which will not test what they were
intending to test.
@bors

bors commented Apr 17, 2021

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 4cfc7b3 with merge 42bee5a...

@bors

bors commented Apr 17, 2021

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing 42bee5a to master...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Apr 17, 2021
@bors
bors merged commit 42bee5a into rust-lang:masterApr 17, 2021
@rustbotrustbot added this to the 1.53.0 milestone Apr 17, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-by-borsThis PR was explicitly merged by bors.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@Aaron1011@rust-highfive@Mark-Simulacrum@bors@rustbot