Uh oh!
There was an error while loading. Please reload this page.
rustdoc: Reduce visual weight of attributes. - #84283
Merged
Merged
Conversation
rust-highfive
commented
Apr 18, 2021
Contributor
Some changes occurred in HTML/CSS/JS. A change occurred in the Ayu theme. cc @Cldfire Some changes occurred in HTML/CSS themes. |
rust-highfive
commented
Apr 18, 2021
Contributor
(rust-highfive has picked a reviewer for you, use r? to override) |
GuillaumeGomez
approved these changes
Apr 18, 2021
GuillaumeGomez
commented
Apr 18, 2021
Member
Thanks! @bors: r+ rollup |
bors
commented
Apr 18, 2021
Collaborator
📌 Commit e23b035 has been approved by |
GuillaumeGomez added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Apr 18, 2021
…llaumeGomez rustdoc: Reduce visual weight of attributes. Followup from rust-lang#83337. As part of that PR, we stopped hiding attributes behind a toggle, because most things have just zero or one attributes. However, this made clear that the current rendering of attributes emphasizes them a lot, which distracts from function signatures. This PR changes their color of attributes to be the same as the toggles, and reduces their font weight. This also removes `#[lang]` from the list of ALLOWED_ATTRIBUTES. This attribute is an implementation detail rather than part of the public-facing documentation.  Demo at https://hoffman-andrews.com/rust/de-emph-attr/std/string/struct.String.html#method.trim
GuillaumeGomez added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Apr 18, 2021
…llaumeGomez rustdoc: Reduce visual weight of attributes. Followup from rust-lang#83337. As part of that PR, we stopped hiding attributes behind a toggle, because most things have just zero or one attributes. However, this made clear that the current rendering of attributes emphasizes them a lot, which distracts from function signatures. This PR changes their color of attributes to be the same as the toggles, and reduces their font weight. This also removes `#[lang]` from the list of ALLOWED_ATTRIBUTES. This attribute is an implementation detail rather than part of the public-facing documentation.  Demo at https://hoffman-andrews.com/rust/de-emph-attr/std/string/struct.String.html#method.trim
GuillaumeGomez added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Apr 18, 2021
…llaumeGomez rustdoc: Reduce visual weight of attributes. Followup from rust-lang#83337. As part of that PR, we stopped hiding attributes behind a toggle, because most things have just zero or one attributes. However, this made clear that the current rendering of attributes emphasizes them a lot, which distracts from function signatures. This PR changes their color of attributes to be the same as the toggles, and reduces their font weight. This also removes `#[lang]` from the list of ALLOWED_ATTRIBUTES. This attribute is an implementation detail rather than part of the public-facing documentation.  Demo at https://hoffman-andrews.com/rust/de-emph-attr/std/string/struct.String.html#method.trim
bors
commented
Apr 19, 2021
Collaborator
bors
commented
Apr 19, 2021
Collaborator
☀️ Test successful - checks-actions |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup from #83337. As part of that PR, we stopped hiding attributes behind a toggle, because most things have just zero or one attributes. However, this made clear that the current rendering of attributes emphasizes them a lot, which distracts from function signatures. This PR changes their color of attributes to be the same as the toggles, and reduces their font weight.
This also removes
#[lang]from the list of ALLOWED_ATTRIBUTES. This attribute is an implementation detail rather than part of the public-facing documentation.Demo at https://hoffman-andrews.com/rust/de-emph-attr/std/string/struct.String.html#method.trim