Uh oh!
There was an error while loading. Please reload this page.
bootstrap: Restore missing --bulk-dirs for rust-docs, rustc-docs - #84289
Merged
Conversation
rust-highfive
commented
Apr 18, 2021
Contributor
(rust-highfive has picked a reviewer for you, use r? to override) |
The --bulk-dirs argument was removed for rust-docs in commit c768ce1 and rustc-docs in commit 8ca46fc (rust-lang#79788), presumably by mistake; that slowed down installation of rust-docs from under a second to some twenty *minutes*. Restoring --bulk-dirs reverses this slowdown. Fixesrust-lang#80684. Signed-off-by: Anders Kaseorg <andersk@mit.edu>
anderskforce-pushed
the
bootstrap-bulk-dir
branch
from
April 18, 2021 06:44
a098910 to
6dfd700CompareMark-Simulacrum
commented
Apr 22, 2021
Member
@bors r+ rollup=never |
bors
commented
Apr 22, 2021
Collaborator
📌 Commit 6dfd700 has been approved by |
bors
commented
Apr 22, 2021
Collaborator
bors
commented
Apr 22, 2021
Collaborator
☀️ Test successful - checks-actions |
gentoo-bot pushed a commit
to gentoo/gentoo
that referenced
this pull request
May 5, 2021
Bug: https://bugs.gentoo.org/783468 X-Upstream-Issue: rust-lang/rust#80684 X-Upstream-Fix: rust-lang/rust#84289 Package-Manager: Portage-3.0.18, Repoman-3.0.3 Signed-off-by: Georgy Yakovlev <gyakovlev@gentoo.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
--bulk-dirsargument was removed for rust-docs in commit c768ce1 and rustc-docs in commit 8ca46fc (#79788), presumably by mistake; that slowed down installation of rust-docs from under a second to some twenty minutes. Restoring--bulk-dirsreverses this slowdown.Fixes#80684.
Cc @pietroalbini.