Skip to content

Uses flex to fix formatting of h1 at any width - #84376

Merged
bors merged 2 commits into
rust-lang:masterfrom
torhovland:issue-84534
Apr 22, 2021
Merged

Uses flex to fix formatting of h1 at any width#84376
bors merged 2 commits into
rust-lang:masterfrom
torhovland:issue-84534

Conversation

@torhovland

@torhovlandtorhovland commented Apr 20, 2021•
edited
Loading

Copy link
Copy Markdown
Contributor

Fixes#84354.

@rust-highfive

rust-highfive commented Apr 20, 2021

Copy link
Copy Markdown
Contributor

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez

@rust-highfive

rust-highfive commented Apr 20, 2021

Copy link
Copy Markdown
Contributor

r? @ollie27

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 20, 2021
GuillaumeGomez
GuillaumeGomez reviewed Apr 21, 2021
View reviewed changes
Comment threadsrc/librustdoc/html/static/rustdoc.css Outdated
@torhovland

torhovland commented Apr 21, 2021

Copy link
Copy Markdown
ContributorAuthor

This looks OK on Safari on iPhone 6, using a fake trait name to demonstrate the wrapping. Tested on a real device using BrowserStack:

iPhone-6

Edge also looks good:

Edge

@torhovland

torhovland commented Apr 21, 2021

Copy link
Copy Markdown
ContributorAuthor

For consistency, I do recommend also changing the other places where .out-of-band is used from float: right to using flex like here.

@GuillaumeGomez

GuillaumeGomez commented Apr 22, 2021

Copy link
Copy Markdown
Member

@torhovland Thanks!

For consistency, I do recommend also changing the other places where .out-of-band is used from float: right to using flex like here.

Do you want to send another PR to improve it as well?

@GuillaumeGomez

GuillaumeGomez commented Apr 22, 2021

Copy link
Copy Markdown
Member

In the meantime:

@bors: r+

@bors

bors commented Apr 22, 2021

Copy link
Copy Markdown
Collaborator

📌 Commit bb91805 has been approved by GuillaumeGomez

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 22, 2021
@torhovland

torhovland commented Apr 22, 2021

Copy link
Copy Markdown
ContributorAuthor

Do you want to send another PR to improve it as well?

Sure, I can give it a shot.

Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Apr 22, 2021
@Dylan-DPC
Rollup merge ofrust-lang#84376- torhovland:issue-84534, r=Guillaume…
3d1b81c
…Gomez
Uses flex to fix formatting of h1 at any width
Fixesrust-lang#84354.
@Dylan-DPC-zzDylan-DPC-zz mentioned this pull request Apr 22, 2021
Closed
@Dylan-DPC-zzDylan-DPC-zz mentioned this pull request Apr 22, 2021
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 22, 2021
@bors
Auto merge ofrust-lang#84440- Dylan-DPC:rollup-0xjb8oi, r=Dylan-DPC
5f1aeb5
Rollup of 7 pull requests
Successful merges:
- rust-lang#84343 (Remove `ScopeTree::closure_tree`)
- rust-lang#84376 (Uses flex to fix formatting of h1 at any width)
- rust-lang#84377 (Followup to rust-lang#83944)
- rust-lang#84396 (Update LLVM submodule)
- rust-lang#84402 (Move `sys_common::rwlock::StaticRWLock` etc. to `sys::unix::rwlock`)
- rust-lang#84404 (Check for intrinsics before coercing to a function pointer)
- rust-lang#84413 (Remove `sys::args::Args::inner_debug` and use `Debug` instead)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
@torhovlandtorhovland mentioned this pull request Apr 22, 2021
Merged
@bors
bors merged commit 7b6fd61 into rust-lang:masterApr 22, 2021
@rustbotrustbot added this to the 1.53.0 milestone Apr 22, 2021
@jshajsha mentioned this pull request Apr 23, 2021
Closed
@GuillaumeGomezGuillaumeGomez added A-rustdoc-ui Area: Rustdoc UI (generated HTML) T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Apr 23, 2021
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Apr 29, 2021
@Dylan-DPC
Rollup merge ofrust-lang#84451- torhovland:flex, r=jsha
a375058
Use flex more consistently
Builds on rust-lang#84376, related to rust-lang#84354.
- Fully replaces `float: right` with `flex` on `.content .out-of-band`.
- Uses `flex` more consistently with existing usage (on `h3`, `h4`, etc.).
Tested on various widths to make sure the pages behave as before.
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Apr 29, 2021
@Dylan-DPC
Rollup merge ofrust-lang#84451- torhovland:flex, r=jsha
1d65997
Use flex more consistently
Builds on rust-lang#84376, related to rust-lang#84354.
- Fully replaces `float: right` with `flex` on `.content .out-of-band`.
- Uses `flex` more consistently with existing usage (on `h3`, `h4`, etc.).
Tested on various widths to make sure the pages behave as before.
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Apr 29, 2021
@Dylan-DPC
Rollup merge ofrust-lang#84451- torhovland:flex, r=jsha
cc57bf6
Use flex more consistently
Builds on rust-lang#84376, related to rust-lang#84354.
- Fully replaces `float: right` with `flex` on `.content .out-of-band`.
- Uses `flex` more consistently with existing usage (on `h3`, `h4`, etc.).
Tested on various widths to make sure the pages behave as before.
jackh726 added a commit to jackh726/rust that referenced this pull request Apr 29, 2021
@jackh726
Rollup merge ofrust-lang#84451- torhovland:flex, r=jsha
9381fe1
Use flex more consistently
Builds on rust-lang#84376, related to rust-lang#84354.
- Fully replaces `float: right` with `flex` on `.content .out-of-band`.
- Uses `flex` more consistently with existing usage (on `h3`, `h4`, etc.).
Tested on various widths to make sure the pages behave as before.
jackh726 added a commit to jackh726/rust that referenced this pull request Apr 29, 2021
@jackh726
Rollup merge ofrust-lang#84451- torhovland:flex, r=jsha
6d18bcf
Use flex more consistently
Builds on rust-lang#84376, related to rust-lang#84354.
- Fully replaces `float: right` with `flex` on `.content .out-of-band`.
- Uses `flex` more consistently with existing usage (on `h3`, `h4`, etc.).
Tested on various widths to make sure the pages behave as before.
jackh726 added a commit to jackh726/rust that referenced this pull request Apr 29, 2021
@jackh726
Rollup merge ofrust-lang#84451- torhovland:flex, r=jsha
3ad9b00
Use flex more consistently
Builds on rust-lang#84376, related to rust-lang#84354.
- Fully replaces `float: right` with `flex` on `.content .out-of-band`.
- Uses `flex` more consistently with existing usage (on `h3`, `h4`, etc.).
Tested on various widths to make sure the pages behave as before.
jackh726 added a commit to jackh726/rust that referenced this pull request Apr 29, 2021
@jackh726
Rollup merge ofrust-lang#84451- torhovland:flex, r=jsha
8f956a3
Use flex more consistently
Builds on rust-lang#84376, related to rust-lang#84354.
- Fully replaces `float: right` with `flex` on `.content .out-of-band`.
- Uses `flex` more consistently with existing usage (on `h3`, `h4`, etc.).
Tested on various widths to make sure the pages behave as before.
jackh726 added a commit to jackh726/rust that referenced this pull request Apr 29, 2021
@jackh726
Rollup merge ofrust-lang#84451- torhovland:flex, r=jsha
2e58633
Use flex more consistently
Builds on rust-lang#84376, related to rust-lang#84354.
- Fully replaces `float: right` with `flex` on `.content .out-of-band`.
- Uses `flex` more consistently with existing usage (on `h3`, `h4`, etc.).
Tested on various widths to make sure the pages behave as before.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GuillaumeGomezGuillaumeGomezGuillaumeGomez left review comments

Assignees

@ollie27ollie27

Labels

A-rustdoc-uiArea: Rustdoc UI (generated HTML)S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.53.0

Development

Successfully merging this pull request may close these issues.

rustdoc: Declaration truncated on small mobile screens

6 participants

@torhovland@rust-highfive@GuillaumeGomez@bors@ollie27@rustbot