Skip to content

Fix ICE if original_span(fn_sig) returns a span not in body sourcefile - #84456

Merged
bors merged 1 commit into
rust-lang:masterfrom
richkadel:issue-84421
Apr 23, 2021
Merged

Fix ICE if original_span(fn_sig) returns a span not in body sourcefile#84456
bors merged 1 commit into
rust-lang:masterfrom
richkadel:issue-84421

Conversation

@richkadel

Copy link
Copy Markdown

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 22, 2021
@tmandry

Copy link
Copy Markdown
Member

@bors r+ rollup

@bors

bors commented Apr 22, 2021

Copy link
Copy Markdown
Collaborator

📌 Commit a07bf2e has been approved by tmandry

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 22, 2021
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Apr 23, 2021
Fix ICE if original_span(fn_sig) returns a span not in body sourcefile
Fixes: rust-lang#84421
r? `@tmandry`
fyi: `@wesleywiser` `@sdroege` `@rajivshah3`
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Apr 23, 2021
Fix ICE if original_span(fn_sig) returns a span not in body sourcefile
Fixes: rust-lang#84421
r? ``@tmandry``
fyi: ``@wesleywiser`` ``@sdroege`` ``@rajivshah3``
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Apr 23, 2021
Fix ICE if original_span(fn_sig) returns a span not in body sourcefile
Fixes: rust-lang#84421
r? ```@tmandry```
fyi: ```@wesleywiser``` ```@sdroege``` ```@rajivshah3```
This was referenced Apr 23, 2021
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 23, 2021
Rollup of 11 pull requests
Successful merges:
- rust-lang#80805 (Improve `Iterator::by_ref` example)
- rust-lang#84248 (Remove duplicated fn(Box<[T]>) -> Vec<T>)
- rust-lang#84321 (rustdoc: Convert sub-variant toggle to HTML)
- rust-lang#84359 (:arrow_up: rust-analyzer)
- rust-lang#84374 (Clean up .gitignore)
- rust-lang#84387 (Move `sys_common::poison` to `sync::poison`)
- rust-lang#84430 (doc/platform-support: clarify UEFI support)
- rust-lang#84433 (Prevent control, shift and alt keys to make search input lose focus)
- rust-lang#84444 (doc: Get rid of "[+] show undocumented items" toggle on numeric From impls)
- rust-lang#84456 (Fix ICE if original_span(fn_sig) returns a span not in body sourcefile)
- rust-lang#84469 (Update comment on `PrimTy::name_str`)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit e07c7b5 into rust-lang:masterApr 23, 2021
@rustbotrustbot added this to the 1.53.0 milestone Apr 23, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

osmesa-sys 0.1.2 ICE with nightly 2021-04-20 and newer and -Z instrument-coverage

5 participants

@richkadel@tmandry@bors@rust-highfive@rustbot