Uh oh!
There was an error while loading. Please reload this page.
Update LLVM for more wasm simd updates - #84654
Merged
Merged
Conversation
rust-highfive
commented
Apr 28, 2021
Contributor
r? @cuviper (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
commented
Apr 28, 2021
Contributor
|
cuviper
commented
Apr 28, 2021
Member
@bors r+ |
bors
commented
Apr 28, 2021
Collaborator
📌 Commit 27fc7cb has been approved by |
7 tasks
Dylan-DPC-zz pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Apr 29, 2021
Update LLVM for more wasm simd updates This fixes the temporary regression introduced in rust-lang#84339 where the wasm target uses `fpto{s,u}i` intrinsics but the codegen for those intrinsics with the `+nontrapping-fptoint` LLVM feature wasn't very good (aka it didn't use the wasm instruction). The fixes brought in here fix that and also implement the second-to-last simd instruction in LLVM.
Dylan-DPC-zz pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Apr 29, 2021
Update LLVM for more wasm simd updates This fixes the temporary regression introduced in rust-lang#84339 where the wasm target uses `fpto{s,u}i` intrinsics but the codegen for those intrinsics with the `+nontrapping-fptoint` LLVM feature wasn't very good (aka it didn't use the wasm instruction). The fixes brought in here fix that and also implement the second-to-last simd instruction in LLVM.
Dylan-DPC-zz pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Apr 29, 2021
Update LLVM for more wasm simd updates This fixes the temporary regression introduced in rust-lang#84339 where the wasm target uses `fpto{s,u}i` intrinsics but the codegen for those intrinsics with the `+nontrapping-fptoint` LLVM feature wasn't very good (aka it didn't use the wasm instruction). The fixes brought in here fix that and also implement the second-to-last simd instruction in LLVM.
JohnTitor
commented
Apr 29, 2021
Member
This likely causes a rollup failure: #84693 (comment) |
This fixes the temporary regression introduced in rust-lang#84339 where the wasm target uses `fpto{s,u}i` intrinsics but the codegen for those intrinsics with the `+nontrapping-fptoint` LLVM feature wasn't very good (aka it didn't use the wasm instruction). The fixes brought in here fix that and also implement the second-to-last simd instruction in LLVM.
alexcrichton
commented
Apr 30, 2021
MemberAuthor
Attempted to fix with rust-lang/llvm-project#106. Pull in that update, but this also pulls in one more commit, so I picked up the Rust changes in #84681 too. @bors: r=cuviper |
bors
commented
Apr 30, 2021
Collaborator
📌 Commit eadcbb5 has been approved by |
Closed
bors
commented
Apr 30, 2021
Collaborator
bors
commented
Apr 30, 2021
Collaborator
☀️ Test successful - checks-actions |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the temporary regression introduced in #84339 where the wasm
target uses
fpto{s,u}iintrinsics but the codegen for those intrinsicswith the
+nontrapping-fptointLLVM feature wasn't very good (aka itdidn't use the wasm instruction). The fixes brought in here fix that and
also implement the second-to-last simd instruction in LLVM.