Skip to content

Update documentation for SharedContext::maybe_collapsed_doc_value - #85141

Merged
bors merged 1 commit into
rust-lang:masterfrom
GuillaumeGomez:maybe_collapsed_doc_value-doc
May 12, 2021
Merged

Update documentation for SharedContext::maybe_collapsed_doc_value#85141
bors merged 1 commit into
rust-lang:masterfrom
GuillaumeGomez:maybe_collapsed_doc_value-doc

Conversation

@GuillaumeGomez

Copy link
Copy Markdown
Member

Fixes#85120.

The doc-collapse was removed, however, the main crate is always "collapsed", meaning that this function is still needed. I updated the documentation instead to avoid misleading readers.

r? @jsha

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 10, 2021
@GuillaumeGomezGuillaumeGomez added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. C-cleanup Category: PRs that clean code up or issues documenting cleanup. labels May 10, 2021
@jsha

jsha commented May 12, 2021

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented May 12, 2021

Copy link
Copy Markdown
Collaborator

📌 Commit 0851995 has been approved by jsha

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 12, 2021
@GuillaumeGomez

Copy link
Copy Markdown
MemberAuthor

@bors: rollup

bors added a commit to rust-lang-ci/rust that referenced this pull request May 12, 2021
…laumeGomez
Rollup of 5 pull requests
Successful merges:
- rust-lang#84793 (Recover from invalid `struct` item syntax)
- rust-lang#85117 (Move global click handlers to per-element ones.)
- rust-lang#85141 (Update documentation for SharedContext::maybe_collapsed_doc_value)
- rust-lang#85174 (Fix border radius for doc code blocks in rustdoc)
- rust-lang#85205 (Update books)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 249ed26 into rust-lang:masterMay 12, 2021
@rustbotrustbot added this to the 1.54.0 milestone May 12, 2021
@GuillaumeGomez
GuillaumeGomez deleted the maybe_collapsed_doc_value-doc branch May 12, 2021 19:18
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-cleanupCategory: PRs that clean code up or issues documenting cleanup.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove rustdoc function maybe_collapsed_doc_value

5 participants

@GuillaumeGomez@jsha@bors@rust-highfive@rustbot