Skip to content

Move available_concurrency implementation to sys - #85182

Merged
bors merged 3 commits into
rust-lang:masterfrom
CDirkx:available_concurrency
Jun 22, 2021
Merged

Move available_concurrency implementation to sys#85182
bors merged 3 commits into
rust-lang:masterfrom
CDirkx:available_concurrency

Conversation

@CDirkx

@CDirkxCDirkx commented May 11, 2021

Copy link
Copy Markdown
Contributor

This splits out the platform-specific implementation of available_concurrency to the corresponding platforms under sys. No changes are made to the implementation.

Tidy didn't lint against this code being originally added outside of sys because of a bug (see #84677), this PR also reverts the exclusion that was introduced in that bugfix.

Tracking issue of available_concurrency: #74479

@rust-highfive

Copy link
Copy Markdown
Contributor

r? @joshtriplett

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 11, 2021
Comment threadlibrary/std/src/sys/windows/c.rs Outdated
Comment threadlibrary/std/src/sys/unix/thread.rs Outdated
@rustbotrustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label May 14, 2021
@JohnCSimonJohnCSimon added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 31, 2021
@CDirkx
CDirkxforce-pushed the available_concurrency branch from 81045b0 to 888418aCompareJune 21, 2021 09:32
@JohnTitor

Copy link
Copy Markdown
Member

Great, thanks!

r? @JohnTitor@bors r+

@bors

bors commented Jun 21, 2021

Copy link
Copy Markdown
Collaborator

📌 Commit 888418a has been approved by JohnTitor

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 21, 2021
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Jun 21, 2021
…nTitor
Move `available_concurrency` implementation to `sys`
This splits out the platform-specific implementation of `available_concurrency` to the corresponding platforms under `sys`. No changes are made to the implementation.
Tidy didn't lint against this code being originally added outside of `sys` because of a bug (see rust-lang#84677), this PR also reverts the exclusion that was introduced in that bugfix.
Tracking issue of `available_concurrency`: rust-lang#74479
This was referenced Jun 21, 2021
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 22, 2021
Rollup of 11 pull requests
Successful merges:
- rust-lang#85054 (Revert SGX inline asm syntax)
- rust-lang#85182 (Move `available_concurrency` implementation to `sys`)
- rust-lang#86037 (Add `io::Cursor::{remaining, remaining_slice, is_empty}`)
- rust-lang#86114 (Reopen rust-lang#79692 (Format symbols under shared frames))
- rust-lang#86297 (Allow to pass arguments to rustdoc-gui tool)
- rust-lang#86334 (Resolve type aliases to the type they point to in intra-doc links)
- rust-lang#86367 (Fix comment about rustc_inherit_overflow_checks in abs().)
- rust-lang#86381 (Add regression test for issue rust-lang#39161)
- rust-lang#86387 (Remove `#[allow(unused_lifetimes)]` which is now unnecessary)
- rust-lang#86398 (Add regression test for issue rust-lang#54685)
- rust-lang#86493 (Say "this enum variant takes"/"this struct takes" instead of "this function takes")
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 7f1a4a2 into rust-lang:masterJun 22, 2021
@rustbotrustbot added this to the 1.55.0 milestone Jun 22, 2021
@CDirkx
CDirkx deleted the available_concurrency branch June 22, 2021 08:34
github-actionsBot pushed a commit to tautschnig/verify-rust-std that referenced this pull request Mar 11, 2025
Rollup of 11 pull requests
Successful merges:
- rust-lang#85054 (Revert SGX inline asm syntax)
- rust-lang#85182 (Move `available_concurrency` implementation to `sys`)
- rust-lang#86037 (Add `io::Cursor::{remaining, remaining_slice, is_empty}`)
- rust-lang#86114 (Reopen rust-lang#79692 (Format symbols under shared frames))
- rust-lang#86297 (Allow to pass arguments to rustdoc-gui tool)
- rust-lang#86334 (Resolve type aliases to the type they point to in intra-doc links)
- rust-lang#86367 (Fix comment about rustc_inherit_overflow_checks in abs().)
- rust-lang#86381 (Add regression test for issue rust-lang#39161)
- rust-lang#86387 (Remove `#[allow(unused_lifetimes)]` which is now unnecessary)
- rust-lang#86398 (Add regression test for issue rust-lang#54685)
- rust-lang#86493 (Say "this enum variant takes"/"this struct takes" instead of "this function takes")
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@CDirkx@rust-highfive@JohnTitor@bors@joshtriplett@JohnCSimon@rustbot