Skip to content

Improve display for "copy-path" button, making it more discreet - #85407

Merged
bors merged 1 commit into
rust-lang:masterfrom
GuillaumeGomez:copy-path-display-improvement
May 18, 2021
Merged

Improve display for "copy-path" button, making it more discreet#85407
bors merged 1 commit into
rust-lang:masterfrom
GuillaumeGomez:copy-path-display-improvement

Conversation

@GuillaumeGomez

@GuillaumeGomezGuillaumeGomez commented May 17, 2021•
edited
Loading

Copy link
Copy Markdown
Member

As suggested by @Nemo157here:

Screenshot from 2021-05-18 11-18-49
Screenshot from 2021-05-18 11-15-06
Screenshot from 2021-05-18 11-18-54
Screenshot from 2021-05-18 11-15-00
Screenshot from 2021-05-18 11-18-58
Screenshot from 2021-05-18 11-19-00

r? @jsha

@GuillaumeGomezGuillaumeGomez added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. A-rustdoc-ui Area: Rustdoc UI (generated HTML) labels May 17, 2021
@rust-highfive

rust-highfive commented May 17, 2021

Copy link
Copy Markdown
Contributor

Some changes occurred in HTML/CSS themes.

cc @GuillaumeGomez

A change occurred in the Ayu theme.

cc @Cldfire

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 17, 2021
@Nemo157

Nemo157 commented May 17, 2021

Copy link
Copy Markdown
Contributor

It could be nice to have a highlight on hover too, since there's no longer the border changing color.

@GuillaumeGomez

GuillaumeGomez commented May 17, 2021

Copy link
Copy Markdown
MemberAuthor

I was thinking about it and thought that the cursor change would be enough. What do you suggest? Making the color a bit lighter?

@Nemo157

Nemo157 commented May 17, 2021

Copy link
Copy Markdown
Contributor

Lighter on the dark themes, darker on the light theme (which would require making the base color on ayu a bit darker so it has somewhere to lighten towards).

@GuillaumeGomez
GuillaumeGomezforce-pushed the copy-path-display-improvement branch from 8029814 to 2009393CompareMay 17, 2021 12:56
@GuillaumeGomez

GuillaumeGomez commented May 17, 2021

Copy link
Copy Markdown
MemberAuthor

I updated the screenshots. The difference is very easy to spot when using it but with just the screenshots, not that much... (mostly on light and dark themes)

@jshajsha changed the title Improve display for "copy-path" button, making it more discreteImprove display for "copy-path" button, making it more discreetMay 17, 2021
@jsha

jsha commented May 17, 2021

Copy link
Copy Markdown
Contributor

This looks good, but why the complex CSS filter? Why not just set a different color?

@GuillaumeGomez

GuillaumeGomez commented May 18, 2021

Copy link
Copy Markdown
MemberAuthor

Because of the svg, we can't change its color easily, we have to use tricks. But since it's only grey, we can simply use filter. Need to update it.

@GuillaumeGomez
GuillaumeGomezforce-pushed the copy-path-display-improvement branch from 2009393 to 5d004c1CompareMay 18, 2021 09:16
@GuillaumeGomez

GuillaumeGomez commented May 18, 2021

Copy link
Copy Markdown
MemberAuthor

Simplified the rules for the same result (and also re-updated the screenshots).

@jsha

jsha commented May 18, 2021

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented May 18, 2021

Copy link
Copy Markdown
Collaborator

📌 Commit 5d004c1 has been approved by jsha

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 18, 2021
@RalfJungRalfJung mentioned this pull request May 18, 2021
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request May 18, 2021
@bors
Auto merge ofrust-lang#85443- RalfJung:rollup-d9gd64t, r=RalfJung
491cf55
Rollup of 7 pull requests
Successful merges:
- rust-lang#84462 (rustdoc: use focus for search navigation)
- rust-lang#85251 (Make `const_generics_defaults` not an incomplete feature)
- rust-lang#85404 (Backport 1.52.1 release notes)
- rust-lang#85407 (Improve display for "copy-path" button, making it more discreet)
- rust-lang#85423 (Don't require cmake on Windows when LLVM isn't being built)
- rust-lang#85428 (Add x.py pre-setup instructions)
- rust-lang#85442 (fix typo)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 6e05a71 into rust-lang:masterMay 18, 2021
@rustbotrustbot added this to the 1.54.0 milestone May 18, 2021
@GuillaumeGomez
GuillaumeGomez deleted the copy-path-display-improvement branch May 18, 2021 20:56
@GuillaumeGomezGuillaumeGomez mentioned this pull request May 18, 2021
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@jshajsha

Labels

A-rustdoc-uiArea: Rustdoc UI (generated HTML)S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.54.0

Development

Successfully merging this pull request may close these issues.

6 participants

@GuillaumeGomez@rust-highfive@Nemo157@jsha@bors@rustbot