Uh oh!
There was an error while loading. Please reload this page.
Swap TargetOptions::linker_is_gnu default from false to true and update targets as appropriate. - #85531
Merged
Conversation
…te targets as appropriate.
rust-highfive
commented
May 21, 2021
Contributor
r? @estebank (rust-highfive has picked a reviewer for you, use r? to override) |
luqmana
commented
May 21, 2021
ContributorAuthor
petrochenkov
commented
May 21, 2021
Contributor
Could you also remove all the |
petrochenkov
commented
May 21, 2021
Contributor
@bors r+ |
bors
commented
May 21, 2021
Collaborator
📌 Commit 3221a5e has been approved by |
jamesmunns
commented
May 21, 2021
Contributor
Thanks @luqmana! |
bors
commented
May 22, 2021
Collaborator
bors
commented
May 22, 2021
Collaborator
☀️ Test successful - checks-actions |
petrochenkov
commented
Jun 3, 2021
Contributor
One more regression from this - #85948. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#85274 gated the
--gc-sectionsflag on targets that specifiedlinker_is_gnuto stop us from passing it to incompatible linkers. But that had the unintended effect of the flag no longer being passed on targets for which it is valid and hence caused a regression in binary size. Given that mostld-style linkers are GNU compatible, this change flips our default forlinker_is_gnufrom false to true. That also means updating the targets that relied on the previous default:Fixes#85519