Skip to content

Don't hide inherent implementations by default - #85602

Merged
bors merged 1 commit into
rust-lang:masterfrom
GuillaumeGomez:donthide-inherent-impls
May 23, 2021
Merged

Don't hide inherent implementations by default#85602
bors merged 1 commit into
rust-lang:masterfrom
GuillaumeGomez:donthide-inherent-impls

Conversation

@GuillaumeGomez

Copy link
Copy Markdown
Member

Fixes a regression introduced in #85575.

r? @jsha

@GuillaumeGomezGuillaumeGomez added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label May 23, 2021
@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 23, 2021
@GuillaumeGomezGuillaumeGomez added the A-rustdoc-ui Area: Rustdoc UI (generated HTML) label May 23, 2021
@jsha

jsha commented May 23, 2021

Copy link
Copy Markdown
Contributor

Thanks for the quick fix, and sorry for the regression.

@bors r+

@bors

bors commented May 23, 2021

Copy link
Copy Markdown
Collaborator

📌 Commit d7579b9 has been approved by jsha

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 23, 2021
@GuillaumeGomez

Copy link
Copy Markdown
MemberAuthor

Since it's a regression fix, let's increase the priority a bit.

@bors: p=1

@bors

bors commented May 23, 2021

Copy link
Copy Markdown
Collaborator

⌛ Testing commit d7579b9 with merge d8af907...

@bors

bors commented May 23, 2021

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions
Approved by: jsha
Pushing d8af907 to master...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label May 23, 2021
@bors
bors merged commit d8af907 into rust-lang:masterMay 23, 2021
@rustbotrustbot added this to the 1.54.0 milestone May 23, 2021
@GuillaumeGomez
GuillaumeGomez deleted the donthide-inherent-impls branch May 23, 2021 19:45
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-rustdoc-uiArea: Rustdoc UI (generated HTML)merged-by-borsThis PR was explicitly merged by bors.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@GuillaumeGomez@jsha@bors@rust-highfive@rustbot