Uh oh!
There was an error while loading. Please reload this page.
Optimize linkchecker and add report. - #85652
Merged
Merged
Conversation
Moves all the state into a struct so it doesn't need to be passed around as much. Also adds a report showing how long it took and what it found. This includes a minor change: a failure to load a file is now an error, instead of being ignored. This should only happen if there is a permission error or some other shenanigans going on.
This should improve performance 2-3x depending on the system.
rust-highfive
commented
May 25, 2021
Contributor
(rust-highfive has picked a reviewer for you, use r? to override) |
Mark-Simulacrum
commented
May 26, 2021
Member
@bors r+ rollup=iffy Thanks for adding some tests! Overall this looks quite reasonable to me. |
bors
commented
May 26, 2021
Collaborator
📌 Commit b6532eb has been approved by |
bors
commented
May 26, 2021
Collaborator
⌛ Testing commit b6532eb with merge 996afbcb0973997a4bc06b0e1d1b8280eb4597bb... |
rust-log-analyzer
commented
May 26, 2021
Collaborator
A job failed! Check out the build log: (web)(plain) Click to see the possible cause of the failure (guessed by this bot) |
bors
commented
May 26, 2021
Collaborator
💔 Test failed - checks-actions |
ehuss
commented
May 26, 2021
ContributorAuthor
@bors retry |
bors
commented
May 26, 2021
Collaborator
bors
commented
May 27, 2021
Collaborator
☀️ Test successful - checks-actions |
JohnTitor added a commit
to JohnTitor/rust
that referenced
this pull request
Jun 3, 2021
…ulacrum Fix linkcheck script from getting out of sync. When there are changes to the linkcheck script, the CI jobs used in the books would download the latest version on master, but run it against nightly. During that 24 hour window, the CI can fail if the script has changes that are incompatible with the last nightly. This fixes it so that it downloads the linkchecker that matches the version of nightly. This also includes a fix to build with release to make it run much faster (I forgot to add this in rust-lang#85652).
JohnTitor added a commit
to JohnTitor/rust
that referenced
this pull request
Jun 4, 2021
…ulacrum Fix linkcheck script from getting out of sync. When there are changes to the linkcheck script, the CI jobs used in the books would download the latest version on master, but run it against nightly. During that 24 hour window, the CI can fail if the script has changes that are incompatible with the last nightly. This fixes it so that it downloads the linkchecker that matches the version of nightly. This also includes a fix to build with release to make it run much faster (I forgot to add this in rust-lang#85652).
JohnTitor added a commit
to JohnTitor/rust
that referenced
this pull request
Jun 21, 2021
…ulacrum Fix a bug in the linkchecker There was a small typo in the linkchecker (in rust-lang#85652) that caused it to report a `#` fragment link error pointing to the wrong file (it was displaying the path to the source file, not the target of the link). This also includes a few other changes: - Fixes the tests due to some changes in the redirect handling in rust-lang#84703. - Adds the tests to rustbuild to run whenever the linkchecker itself is run. - Updates the tests to validate more of the output (so that a mistake like this would have been caught). Closesrust-lang#86144
JohnTitor added a commit
to JohnTitor/rust
that referenced
this pull request
Jun 21, 2021
…ulacrum Fix a bug in the linkchecker There was a small typo in the linkchecker (in rust-lang#85652) that caused it to report a `#` fragment link error pointing to the wrong file (it was displaying the path to the source file, not the target of the link). This also includes a few other changes: - Fixes the tests due to some changes in the redirect handling in rust-lang#84703. - Adds the tests to rustbuild to run whenever the linkchecker itself is run. - Updates the tests to validate more of the output (so that a mistake like this would have been caught). Closesrust-lang#86144
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes three changes to the linkchecker: