RFC-2841: add codegen flag export symbols from executable by csmoe · Pull Request #85673 · rust-lang/rust

csmoe · 2021-05-25T14:35:03Z

Closes#84161
r? @nikomatsakis @Mark-Simulacrum

crlf0710 · 2021-06-11T11:14:01Z

@csmoe Ping from triage, CI is still red here. Would you mind fixing that?

nikomatsakis

Hmm, do we have any tests for symbol visibility? Maybe in the run-make folder? It'd be good to have a test for this.

crlf0710 · 2021-07-09T11:08:16Z

@csmoe Ping from triage, would you mind adding the tests?

csmoe · 2021-09-12T13:38:12Z

@bjorn3-Cexport-executable-symbols seems not work at all as dlopen errors with undefined symbol: exported_symbol, RUSTC_LOG=rustc_codegen_ssa::back::linker=debug printed that the symbol was exported indeed:

 INFO rustc_codegen_ssa::back::link preparing Executable to "main"
DEBUG rustc_codegen_ssa::back::linker EXPORTED SYMBOLS:
DEBUG rustc_codegen_ssa::back::linker exported_symbol;
DEBUG rustc_codegen_ssa::back::linker main;
DEBUG rustc_codegen_ssa::back::linker rust_eh_personality;

Need more help to move on 😿
(btw, don't know why the CI did not error on the test)

bjorn3 · 2021-09-12T14:33:59Z

Are you on Linux or macOS? What is the full linker invocation?

csmoe · 2021-09-13T13:50:20Z

"cc" "-Wl,--version-script=/repo/rust/./rustcqC1COd/list" "-m64" "main.main.cbc7ddee-cgu.0.rcgu.o" "main.main.cbc7ddee-cgu.1.rcgu.o" "main.main.cbc7ddee-cgu.10.rcgu.o" "main.main.cbc7ddee-cgu.11.rcgu.o" "main.main.cbc7ddee-cgu.12.rcgu.o" "main.main.cbc7ddee-cgu.13.rcgu.o" "main.main.cbc7ddee-cgu.14.rcgu.o" "main.main.cbc7ddee-cgu.15.rcgu.o" "main.main.cbc7ddee-cgu.2.rcgu.o" "main.main.cbc7ddee-cgu.3.rcgu.o" "main.main.cbc7ddee-cgu.4.rcgu.o" "main.main.cbc7ddee-cgu.5.rcgu.o" "main.main.cbc7ddee-cgu.6.rcgu.o" "main.main.cbc7ddee-cgu.7.rcgu.o" "main.main.cbc7ddee-cgu.8.rcgu.o" "main.main.cbc7ddee-cgu.9.rcgu.o" "main.4kqwyhdgeomtzpxx.rcgu.o" "-Wl,--as-needed" "-L" "/repo/rust/build/x86_64-unknown-linux-gnu/stage1/lib/rustlib/x86_64-unknown-linux-gnu/lib" "-Wl,--start-group" "-Wl,-Bstatic" "/repo/rust/build/x86_64-unknown-linux-gnu/stage1/lib/rustlib/x86_64-unknown-linux-gnu/lib/libstd-ea06e5b9ebe84ef4.rlib" "/repo/rust/build/x86_64-unknown-linux-gnu/stage1/lib/rustlib/x86_64-unknown-linux-gnu/lib/libpanic_unwind-608126472e4595bf.rlib" "/repo/rust/build/x86_64-unknown-linux-gnu/stage1/lib/rustlib/x86_64-unknown-linux-gnu/lib/libminiz_oxide-96b872de832ae456.rlib" "/repo/rust/build/x86_64-unknown-linux-gnu/stage1/lib/rustlib/x86_64-unknown-linux-gnu/lib/libadler-c96f7126ed0a8243.rlib" "/repo/rust/build/x86_64-unknown-linux-gnu/stage1/lib/rustlib/x86_64-unknown-linux-gnu/lib/libobject-d4333fc5a8e6acd5.rlib" "/repo/rust/build/x86_64-unknown-linux-gnu/stage1/lib/rustlib/x86_64-unknown-linux-gnu/lib/libmemchr-286e391a7bef4a33.rlib" "/repo/rust/build/x86_64-unknown-linux-gnu/stage1/lib/rustlib/x86_64-unknown-linux-gnu/lib/libaddr2line-9b3b5b41ef9d89ac.rlib" "/repo/rust/build/x86_64-unknown-linux-gnu/stage1/lib/rustlib/x86_64-unknown-linux-gnu/lib/libgimli-a01624f3c4d2f24b.rlib" "/repo/rust/build/x86_64-unknown-linux-gnu/stage1/lib/rustlib/x86_64-unknown-linux-gnu/lib/libstd_detect-606d386967062702.rlib" "/repo/rust/build/x86_64-unknown-linux-gnu/stage1/lib/rustlib/x86_64-unknown-linux-gnu/lib/librustc_demangle-9fec6174a0598006.rlib" "/repo/rust/build/x86_64-unknown-linux-gnu/stage1/lib/rustlib/x86_64-unknown-linux-gnu/lib/libhashbrown-612142634ae08506.rlib" "/repo/rust/build/x86_64-unknown-linux-gnu/stage1/lib/rustlib/x86_64-unknown-linux-gnu/lib/librustc_std_workspace_alloc-8a18ecd4776dc12c.rlib" "/repo/rust/build/x86_64-unknown-linux-gnu/stage1/lib/rustlib/x86_64-unknown-linux-gnu/lib/libunwind-11234a29b766d417.rlib" "/repo/rust/build/x86_64-unknown-linux-gnu/stage1/lib/rustlib/x86_64-unknown-linux-gnu/lib/libcfg_if-5c49a6fde622d4a9.rlib" "/repo/rust/build/x86_64-unknown-linux-gnu/stage1/lib/rustlib/x86_64-unknown-linux-gnu/lib/liblibc-01242e2bb437fc18.rlib" "/repo/rust/build/x86_64-unknown-linux-gnu/stage1/lib/rustlib/x86_64-unknown-linux-gnu/lib/liballoc-a1d9b6c563f72c92.rlib" "/repo/rust/build/x86_64-unknown-linux-gnu/stage1/lib/rustlib/x86_64-unknown-linux-gnu/lib/librustc_std_workspace_core-5a76a6f677cfd881.rlib" "/repo/rust/build/x86_64-unknown-linux-gnu/stage1/lib/rustlib/x86_64-unknown-linux-gnu/lib/libcore-99c01d738b9e1246.rlib" "-Wl,--end-group" "/repo/rust/build/x86_64-unknown-linux-gnu/stage1/lib/rustlib/x86_64-unknown-linux-gnu/lib/libcompiler_builtins-8ee0ab4b35b97256.rlib" "-Wl,-Bdynamic" "-lgcc_s" "-lutil" "-lrt" "-lpthread" "-lm" "-ldl" "-lc" "-Wl,--eh-frame-hdr" "-Wl,-znoexecstack" "-L" "/repo/rust/build/x86_64-unknown-linux-gnu/stage1/lib/rustlib/x86_64-unknown-linux-gnu/lib" "-o" "main" "-Wl,--gc-sections" "-pie" "-Wl,-zrelro" "-Wl,-znow" "-nodefaultlibs"

@bjorn3 linux, cc args as above.

bjorn3 · 2021-09-13T14:49:46Z

Could you compile with -Csave-temps and post contents of the version script passed to -Wl,--version-script=?

bjorn3 · 2021-09-13T14:51:48Z

Maybe --gc-keep-exported is necessary?

When --gc-sections is enabled, this option prevents garbage collection of unused input sections that contain global symbols having default or protected visibility. This
option is intended to be used for executables where unreferenced sections would otherwise be garbage collected regardless of the external visibility of contained symbols.
Note that this option has no effect when linking shared objects since it is already the default behaviour. This option is only supported for ELF format targets.

csmoe · 2021-09-14T06:44:46Z

@bjorn3 version-script:

08:40 $ cat rustcXKEpHW/list
{
global:
exported_symbol;
main;
rust_eh_personality;
local:
*;
};

--gc-keep-exported is not available in old gcc(v6.3.0), I'll try a newer.

bjorn3 · 2022-07-20T09:53:52Z

Maybe use crate_type != Executable || !export_executable_symbols?

bjorn3 · 2022-07-20T09:59:21Z

I am not entirely confident in -Zexport-executable-symbols being implemented correctly here, but I am confident that this doesn't break anything if -Zexport-executable-symbols isn't used. As such r=me with or without my nits above.

csmoe · 2022-07-20T13:49:41Z

I tested locally in a small crate with

#[no_mangle]#[test]pubfntest_foo(){ ...}

the test_foo symbol was exported as expected in the unit test executable.

bjorn3 · 2022-07-21T12:30:03Z

@bors r+

bors · 2022-07-21T12:30:05Z

📌 Commit 419e62fa4bad3447421437d96053d2bbe27fe92a has been approved by bjorn3

It is now in the queue for this repository.

bors · 2022-07-21T13:08:21Z

☔ The latest upstream changes (presumably #98162) made this pull request unmergeable. Please resolve the merge conflicts.

bjorn3 · 2022-07-21T14:01:07Z

@bors r+

bors · 2022-07-21T14:01:09Z

📌 Commit 4ae6ff3e91ba8f62049667fc960791f0c342f145 has been approved by bjorn3

It is now in the queue for this repository.

bors · 2022-07-21T16:38:27Z

⌛ Testing commit 4ae6ff3e91ba8f62049667fc960791f0c342f145 with merge 00bddad26f9229d8db1983b7ebf87fec998dd206...

bors · 2022-07-21T17:02:25Z

💔 Test failed - checks-actions

bjorn3 · 2022-07-21T18:33:38Z

The test needs to be ignored on nvptx64-nvidia-cuda. Maybe an // only-unix annotation works? Not sure if that is valid though.

csmoe · 2022-07-21T22:45:24Z

only-unix seems not working, as it ignored linux. I just limited the test with only-linux.

bjorn3 · 2022-07-22T05:32:29Z

👍 Could you please squash? I noticed that one of the commits introduced merge conflict markers which another solves again. And besides, this is pretty much an atimic change. r=me after squashing

csmoe · 2022-07-25T05:22:14Z

@bors r=@bjorn3

bors · 2022-07-25T05:22:16Z

@csmoe: 🔑 Insufficient privileges: Not in reviewers

bjorn3 · 2022-07-25T10:42:18Z

@bors r+

bors · 2022-07-25T10:42:20Z

📌 Commit 6674c94 has been approved by bjorn3

It is now in the queue for this repository.

bors · 2022-07-25T14:04:43Z

⌛ Testing commit 6674c94 with merge dc2d232...

bors · 2022-07-25T16:47:56Z

☀️ Test successful - checks-actions
Approved by: bjorn3
Pushing dc2d232 to master...

bjorn3 · 2022-07-25T16:50:58Z

That only took 10 tries...

rust-timer · 2022-07-25T18:27:59Z

Finished benchmarking commit (dc2d232): comparison url.

Instruction count

Primary benchmarks: no relevant changes found
Secondary benchmarks: 🎉 relevant improvement found

	mean¹	max	count²
Regressions 😿 (primary)	N/A	N/A	0
Regressions 😿 (secondary)	N/A	N/A	0
Improvements 🎉 (primary)	N/A	N/A	0
Improvements 🎉 (secondary)	-0.2%	-0.2%	1
All 😿🎉 (primary)	N/A	N/A	0

Max RSS (memory usage)

Results

Primary benchmarks: no relevant changes found
Secondary benchmarks: 😿 relevant regression found

	mean¹	max	count²
Regressions 😿 (primary)	N/A	N/A	0
Regressions 😿 (secondary)	2.7%	2.7%	1
Improvements 🎉 (primary)	N/A	N/A	0
Improvements 🎉 (secondary)	N/A	N/A	0
All 😿🎉 (primary)	N/A	N/A	0

Cycles

Results

Primary benchmarks: 😿 relevant regression found
Secondary benchmarks: mixed results

	mean¹	max	count²
Regressions 😿 (primary)	2.3%	2.3%	1
Regressions 😿 (secondary)	2.9%	3.8%	4
Improvements 🎉 (primary)	N/A	N/A	0
Improvements 🎉 (secondary)	-2.3%	-2.6%	4
All 😿🎉 (primary)	2.3%	2.3%	1

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

the arithmetic mean of the percent change↩↩² ↩³
number of relevant changes↩↩² ↩³

rust-highfive assigned nikomatsakis May 25, 2021

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 25, 2021

This comment has been minimized.
Sign in to view

crlf0710 added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 11, 2021

bjorn3 reviewed Jun 11, 2021
View reviewed changes

Comment threadcompiler/rustc_interface/src/tests.rs Outdated

bjorn3 reviewed Jun 11, 2021
View reviewed changes

Comment threadcompiler/rustc_session/src/options.rs Outdated

csmoe force-pushed the export-exe-sym branch from 01d7d39 to c81878fCompare June 17, 2021 10:01

nikomatsakis requested changes Jun 23, 2021
View reviewed changes

JohnCSimon added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 25, 2021

csmoe force-pushed the export-exe-sym branch from c81878f to c039c37Compare August 8, 2021 10:22

This comment has been minimized.
Sign in to view

nikomatsakis requested changes Aug 17, 2021
View reviewed changes

Comment threadsrc/test/run-make/export-executable-symbols/main.rs Outdated

csmoe force-pushed the export-exe-sym branch 2 times, most recently from 79e3b3d to 6b14c11Compare August 22, 2021 13:35

bjorn3 reviewed Aug 22, 2021
View reviewed changes

Comment threadsrc/test/run-make/export-executable-symbols/main.rs Outdated

nikomatsakis requested changes Aug 23, 2021
View reviewed changes

Comment threadsrc/test/run-make/export-executable-symbols/main.rs Outdated

JohnCSimon added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 12, 2021

csmoe force-pushed the export-exe-sym branch from 6b14c11 to 15fc513Compare September 12, 2021 13:34

This comment has been minimized.
Sign in to view

bjorn3 reviewed Jul 20, 2022
View reviewed changes

This comment has been minimized.
Sign in to view

bjorn3 reviewed Jul 20, 2022
View reviewed changes

Comment threadcompiler/rustc_codegen_ssa/src/back/link.rs Outdated

This comment has been minimized.
Sign in to view

feat: impl export-executable-symbols
6674c94

bors mentioned this pull request Jul 25, 2022
lint: add bad opt access internal lint #99710
Merged

nagisa mentioned this pull request Aug 1, 2022
Tracking Issue for -C export-executable-symbols#84161
Open
3 tasks

matthiaskrgr mentioned this pull request Apr 28, 2023
ICE: ast lowering: no entry for node id: NodeId(53)#110899
Closed

matthiaskrgr mentioned this pull request Mar 22, 2024
ICE: no entry for node id: 'NodeId(53)'#122903
Open

Uh oh!

Uh oh!

Conversation

csmoe commented May 25, 2021

Uh oh!

This comment has been minimized.

crlf0710 commented Jun 11, 2021

Uh oh!

Uh oh!

Uh oh!

nikomatsakis left a comment

Choose a reason for hiding this comment

Uh oh!

crlf0710 commented Jul 9, 2021

Uh oh!

This comment has been minimized.

Uh oh!

Uh oh!

Uh oh!

csmoe commented Sep 12, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bjorn3 commented Sep 12, 2021

Uh oh!

csmoe commented Sep 13, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bjorn3 commented Sep 13, 2021

Uh oh!

bjorn3 commented Sep 13, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

csmoe commented Sep 14, 2021

Uh oh!

This comment has been minimized.

bjorn3Jul 20, 2022

Choose a reason for hiding this comment

Uh oh!

bjorn3 commented Jul 20, 2022

Uh oh!

csmoe commented Jul 20, 2022

Uh oh!

This comment has been minimized.

This comment has been minimized.

Uh oh!

bjorn3 commented Jul 21, 2022

Uh oh!

bors commented Jul 21, 2022

Uh oh!

bors commented Jul 21, 2022

Uh oh!

bjorn3 commented Jul 21, 2022

Uh oh!

bors commented Jul 21, 2022

Uh oh!

bors commented Jul 21, 2022

Uh oh!

bors commented Jul 21, 2022

Uh oh!

bjorn3 commented Jul 21, 2022

Uh oh!

This comment has been minimized.

csmoe commented Jul 21, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bjorn3 commented Jul 22, 2022

Uh oh!

csmoe commented Jul 25, 2022

Uh oh!

bors commented Jul 25, 2022

Uh oh!

bjorn3 commented Jul 25, 2022

Uh oh!

bors commented Jul 25, 2022

Uh oh!

bors commented Jul 25, 2022

Uh oh!

bors commented Jul 25, 2022

Uh oh!

bjorn3 commented Jul 25, 2022

csmoe commented Sep 12, 2021•
edited
Loading

csmoe commented Sep 13, 2021•
edited
Loading

bjorn3 commented Sep 13, 2021•
edited
Loading

csmoe commented Jul 21, 2022•
edited
Loading