Uh oh!
There was an error while loading. Please reload this page.
Rollup of 7 pull requests - #86079
Closed
GuillaumeGomez wants to merge 16 commits into
Closed
Conversation
This code has been dead since changes in 68961.
The else branch is taken when projection slice is empty so everything except for the call to the `visit_local` is a dead code.
Only register `WSACleanup` if `WSAStartup` is actually ever called Fix for rust-lang#85441. Because `WSACleanup` appears in `cleanup` currently `WS2_32.dll` is always linked, even if no network functionality is ever used. To prevent this, `WSACleanup` has to only appear in `init`, hence the workaround of registering it in a static. If anyone knows a cleaner solution, let me know.
Use `Iterator::any` and `filter_map` instead of open-coding them `@rustbot` modify labels +C-cleanup +T-compiler
Remove dead code from `LocalAnalyzer`
…ochenkov
Unify duplicate linker_and_flavor methods in rustc_codegen_{cranelift,ssa}.
The two methods were exactly the same so this removes the cranelift copy. This will help make sure both they don't get out of sync.…y-height, r=jsha Fix display for search results This fixes unwanted margin and font-weight coming from `.method`. Before:  after:  r? `@jsha`
…kh726 Remove `_` from E0121 diagnostic suggestions Fixesrust-lang#86021.
…eGomez Fix corrected example in E0759.md This pull request fixesrust-lang#86061, which was probably caused by a copy-paste error, where the supposedly corrected code example was also marked with `compile_fail`. Thus, the fact that the "correct" example actually _isn't_ correct was not caught by the doc-tests. This pull request removes the incorrect `compile_fail` annotation and fixes the example. r? `@GuillaumeGomez`
GuillaumeGomez
commented
Jun 6, 2021
MemberAuthor
@bors: r+ p=7 rollup=never |
bors
commented
Jun 6, 2021
Collaborator
📌 Commit b3e1061 has been approved by |
bors
commented
Jun 6, 2021
Collaborator
⌛ Testing commit b3e1061 with merge 95201a3b8f64c0951b815b591311443dead96b01... |
rust-log-analyzer
commented
Jun 6, 2021
Collaborator
The job Click to see the possible cause of the failure (guessed by this bot) |
bors
commented
Jun 6, 2021
Collaborator
💔 Test failed - checks-actions |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
WSACleanupifWSAStartupis actually ever called #85595 (Only registerWSACleanupifWSAStartupis actually ever called)Iterator::anyandfilter_mapinstead of open-coding them #85912 (UseIterator::anyandfilter_mapinstead of open-coding them)LocalAnalyzer#85965 (Remove dead code fromLocalAnalyzer)_from E0121 diagnostic suggestions #86058 (Remove_from E0121 diagnostic suggestions)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup