Skip to content

Create different inference variables for different defining uses of TAITs - #86118

Merged
bors merged 18 commits into
rust-lang:masterfrom
spastorino:tait-soundness-bug
Jun 9, 2021
Merged

Create different inference variables for different defining uses of TAITs#86118
bors merged 18 commits into
rust-lang:masterfrom
spastorino:tait-soundness-bug

Conversation

@spastorino

@spastorinospastorino commented Jun 7, 2021

Copy link
Copy Markdown
Member

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 7, 2021
spastorino
spastorino commented Jun 7, 2021
View reviewed changes
Comment threadcompiler/rustc_mir/src/borrow_check/type_check/mod.rs Outdated
nikomatsakis
nikomatsakis approved these changes Jun 8, 2021
View reviewed changes

@nikomatsakisnikomatsakis left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very nice :)

Comment threadcompiler/rustc_trait_selection/src/opaque_types.rs
Comment threadcompiler/rustc_typeck/src/check/check.rs Outdated
Comment threadcompiler/rustc_typeck/src/check/writeback.rs Outdated
Comment threadcompiler/rustc_trait_selection/src/opaque_types.rs Outdated
Comment threadcompiler/rustc_typeck/src/check/check.rs Outdated
@nikomatsakis

nikomatsakis commented Jun 8, 2021

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented Jun 8, 2021

Copy link
Copy Markdown
Collaborator

@nikomatsakis: 🔑 Insufficient privileges: Not in reviewers

@nikomatsakis

nikomatsakis commented Jun 8, 2021

Copy link
Copy Markdown
Contributor

@rust-lang/infra huh?

@lqd

lqd commented Jun 8, 2021•
edited
Loading

Copy link
Copy Markdown
Member

@nikomatsakishalf of github is still down

@rust-log-analyzer

This comment has been minimized.

Sign in to view
nikomatsakis
nikomatsakis requested changes Jun 8, 2021
View reviewed changes

@nikomatsakisnikomatsakis left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some style nits!

Comment threadcompiler/rustc_data_structures/src/vec_map.rs Outdated
Comment threadcompiler/rustc_data_structures/src/vec_map.rs Outdated
Comment threadcompiler/rustc_data_structures/src/vec_map.rs Outdated
Comment threadcompiler/rustc_typeck/src/check/writeback.rs Outdated
Comment threadcompiler/rustc_typeck/src/check/writeback.rs Outdated
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@nikomatsakis

nikomatsakis commented Jun 8, 2021

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented Jun 8, 2021

Copy link
Copy Markdown
Collaborator

📌 Commit 7b1e1c7 has been approved by nikomatsakis

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 8, 2021
@klensy

klensy commented Jun 8, 2021

Copy link
Copy Markdown
Contributor

This changes used data structures, so should(?) affect perf.

@nikomatsakis

nikomatsakis commented Jun 8, 2021•
edited
Loading

Copy link
Copy Markdown
Contributor

@bors rollup=never

I am fairly confident this will not have an effect on perf, but it'd be good for any effect it MAY have to be isolated.

@bors

bors commented Jun 9, 2021

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 7b1e1c7 with merge c4b5406...

@bors

bors commented Jun 9, 2021

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions
Approved by: nikomatsakis
Pushing c4b5406 to master...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Jun 9, 2021
@bors
bors merged commit c4b5406 into rust-lang:masterJun 9, 2021
@rustbotrustbot added this to the 1.54.0 milestone Jun 9, 2021
This was referenced Jun 10, 2021
Closed
Merged
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Jun 21, 2021
@JohnTitor
Rollup merge ofrust-lang#86248- JohnTitor:issue-85113, r=Mark-Simul…
ac41056
…acrum
Add a regression test for issue-85113
Fixed by rust-lang#86118, closesrust-lang#85113
@michaelwoeristermichaelwoerister mentioned this pull request Jul 5, 2022
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nikomatsakisnikomatsakisnikomatsakis approved these changes

Assignees

@nikomatsakisnikomatsakis

Labels

merged-by-borsThis PR was explicitly merged by bors.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

1.54.0

Development

Successfully merging this pull request may close these issues.

Multiple defining uses of type alias impl trait in single function are not handled

8 participants

@spastorino@nikomatsakis@bors@lqd@rust-log-analyzer@klensy@rust-highfive@rustbot