Skip to content

Beta targetted Make copy/copy_nonoverlapping fn's again - #86203

Merged
bors merged 7 commits into
rust-lang:betafrom
pnkfelix:beta-targetted-issue-84297
Jun 11, 2021
Merged

Beta targetted Make copy/copy_nonoverlapping fn's again #86203
bors merged 7 commits into
rust-lang:betafrom
pnkfelix:beta-targetted-issue-84297

Conversation

@pnkfelix

Copy link
Copy Markdown
Contributor

beta backport of PR #86003

to address issue #84297

This is preparation for reverting 81238 for short-term resolution of issue 84297.
…pping`.
Test was added in PR rust-lang#84404.
The intent here is: The `copy`/`copy_overlapping` intrinsics are going through
some flip-flopping now of "are they intrinsics or not". We can achieve the same
effect that the test intended by using `likely`/`unlikely`.
@rust-highfive

Copy link
Copy Markdown
Contributor

Some changes occurred in src/tools/clippy.

cc @rust-lang/clippy

@rust-highfive

Copy link
Copy Markdown
Contributor

r? @dtolnay

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive

Copy link
Copy Markdown
Contributor

⚠️Warning⚠️

  • Pull requests are usually filed against the master branch for this repo, but this one is against beta. Please double check that you specified the right target!

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 10, 2021
@pnkfelixpnkfelix changed the title Beta targetted Make copy/copy_nonoverlapping fn's again [wip] Beta targetted Make copy/copy_nonoverlapping fn's again Jun 10, 2021
@pnkfelixpnkfelix changed the title [wip] Beta targetted Make copy/copy_nonoverlapping fn's again Beta targetted Make copy/copy_nonoverlapping fn's again Jun 11, 2021
@dtolnay

dtolnay commented Jun 11, 2021

Copy link
Copy Markdown
Member

@bors r+

Approving because #86003 is labelled beta-accepted.

@bors

bors commented Jun 11, 2021

Copy link
Copy Markdown
Collaborator

📌 Commit 61520c8 has been approved by dtolnay

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 11, 2021
@bors

bors commented Jun 11, 2021

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 61520c8 with merge 05f39bf...

@bors

bors commented Jun 11, 2021

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions
Approved by: dtolnay
Pushing 05f39bf to beta...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Jun 11, 2021
@bors
bors merged commit 05f39bf into rust-lang:betaJun 11, 2021
@rustbotrustbot added this to the 1.53.0 milestone Jun 11, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-by-borsThis PR was explicitly merged by bors.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@pnkfelix@rust-highfive@dtolnay@bors@rustbot