Skip to content

Improve maybe_uninit_extra docs - #86220

Merged
bors merged 1 commit into
rust-lang:masterfrom
est31:maybe-uninit-extra
Jun 15, 2021
Merged

Improve maybe_uninit_extra docs#86220
bors merged 1 commit into
rust-lang:masterfrom
est31:maybe-uninit-extra

Conversation

@est31

@est31est31 commented Jun 11, 2021

Copy link
Copy Markdown
Member

For reasoning, see #63567 (comment)

@rust-highfive

rust-highfive commented Jun 11, 2021

Copy link
Copy Markdown
Contributor

r? @scottmcm

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 11, 2021
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@est31
est31force-pushed the maybe-uninit-extra branch from f328e11 to 6036fdbCompareJune 11, 2021 14:18
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@est31
est31force-pushed the maybe-uninit-extra branch from 6036fdb to 24190f4CompareJune 11, 2021 14:50
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@est31
est31force-pushed the maybe-uninit-extra branch from 24190f4 to 4345b1eCompareJune 11, 2021 15:20
@est31est31 mentioned this pull request Jun 12, 2021
Closed
@est31
est31force-pushed the maybe-uninit-extra branch from 4345b1e to e441af7CompareJune 12, 2021 13:39
RalfJung
RalfJung reviewed Jun 13, 2021
View reviewed changes
Comment threadlibrary/core/src/mem/maybe_uninit.rs Outdated
@RalfJung

This comment has been minimized.

Sign in to view
@RalfJung

RalfJung commented Jun 13, 2021

Copy link
Copy Markdown
Member

Argh, sorry, GH autocomplete went really wrong here...
r? @RalfJung

RalfJung
RalfJung reviewed Jun 13, 2021
View reviewed changes
Comment threadlibrary/core/src/mem/maybe_uninit.rs Outdated
@est31
est31force-pushed the maybe-uninit-extra branch from e441af7 to ef6c9e6CompareJune 13, 2021 10:00
RalfJung
RalfJung reviewed Jun 13, 2021
View reviewed changes
Comment threadlibrary/core/src/mem/maybe_uninit.rs Outdated
@est31
est31force-pushed the maybe-uninit-extra branch from ef6c9e6 to 2375604CompareJune 13, 2021 19:00
RalfJung
RalfJung reviewed Jun 13, 2021
View reviewed changes
Comment threadlibrary/core/src/mem/maybe_uninit.rs Outdated
@est31
est31force-pushed the maybe-uninit-extra branch from 2375604 to db76996CompareJune 14, 2021 10:30
RalfJung
RalfJung reviewed Jun 14, 2021
View reviewed changes
Comment threadlibrary/core/src/mem/maybe_uninit.rs Outdated
@RalfJung

RalfJung commented Jun 14, 2021

Copy link
Copy Markdown
Member

r=me with the last wording nit resolved.
@bors delegate+

@bors

bors commented Jun 14, 2021

Copy link
Copy Markdown
Collaborator

✌️ @est31 can now approve this pull request

@est31
est31force-pushed the maybe-uninit-extra branch from db76996 to 8710258CompareJune 14, 2021 11:31
@est31

est31 commented Jun 14, 2021

Copy link
Copy Markdown
MemberAuthor

@bors r=RalfJung rollup

@bors

bors commented Jun 14, 2021

Copy link
Copy Markdown
Collaborator

📌 Commit 8710258 has been approved by RalfJung

@borsbors removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 14, 2021
@borsbors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jun 14, 2021
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Jun 14, 2021
@Dylan-DPC
Rollup merge ofrust-lang#86220- est31:maybe-uninit-extra, r=RalfJung
9d37ecc
Improve maybe_uninit_extra docs
For reasoning, see rust-lang#63567 (comment)
@Dylan-DPC-zzDylan-DPC-zz mentioned this pull request Jun 14, 2021
Closed
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Jun 14, 2021
@Dylan-DPC
Rollup merge ofrust-lang#86220- est31:maybe-uninit-extra, r=RalfJung
8373c01
Improve maybe_uninit_extra docs
For reasoning, see rust-lang#63567 (comment)
@Dylan-DPC-zzDylan-DPC-zz mentioned this pull request Jun 14, 2021
Closed
@JohnTitorJohnTitor mentioned this pull request Jun 15, 2021
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 15, 2021
@bors
Auto merge ofrust-lang#86321- JohnTitor:rollup-q61c8q4, r=JohnTitor
607d6b0
Rollup of 10 pull requests
Successful merges:
- rust-lang#80269 (Explain non-dropped sender recv in docs)
- rust-lang#82179 (Add functions `Duration::try_from_secs_{f32, f64}`)
- rust-lang#85608 (Stabilize `ops::ControlFlow` (just the type))
- rust-lang#85792 (Refactor windows sockets impl methods)
- rust-lang#86220 (Improve maybe_uninit_extra docs)
- rust-lang#86277 (Remove must_use from ALLOWED_ATTRIBUTES)
- rust-lang#86285 (:arrow_up: rust-analyzer)
- rust-lang#86294 (Stabilize {std, core}::prelude::rust_*.)
- rust-lang#86306 (Add mailmap entries for myself)
- rust-lang#86314 (Remove trailing triple backticks in `mut_keyword` docs)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit e84ee52 into rust-lang:masterJun 15, 2021
@rustbotrustbot added this to the 1.55.0 milestone Jun 15, 2021
@est31est31 mentioned this pull request Jun 16, 2021
Merged
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Jul 12, 2021
@JohnTitor
Rollup merge ofrust-lang#86344- est31:maybe-uninit-extra, r=RalfJung
b507cd1
Split MaybeUninit::write into new feature gate and stabilize it
This splits off the `MaybeUninit::write` function from the `maybe_uninit_extra` feature gate into a new `maybe_uninit_write` feature gate and stabilizes it.
Earlier work to improve the documentation of the write function: rust-lang#86220
Tracking issue: rust-lang#63567
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RalfJungRalfJungRalfJung left review comments

Assignees

@RalfJungRalfJung

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

1.55.0

Development

Successfully merging this pull request may close these issues.

7 participants

@est31@rust-highfive@rust-log-analyzer@RalfJung@bors@scottmcm@rustbot