Uh oh!
There was an error while loading. Please reload this page.
[beta] backport: Remove unsound TrustedRandomAccess implementations - #86222
Closed
steffahn wants to merge 1 commit into
Closed
[beta] backport: Remove unsound TrustedRandomAccess implementations#86222steffahn wants to merge 1 commit into
steffahn wants to merge 1 commit into
Conversation
Removes the implementations that depend on the user-definable trait `Copy`. Beta backport: Does not modify `vec::IntoIter`.
rust-highfive
commented
Jun 11, 2021
Contributor
r? @m-ou-se (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
commented
Jun 11, 2021
Contributor
|
steffahn
commented
Jun 11, 2021
MemberAuthor
cc @pnkfelix |
Merged
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 11, 2021
…ulacrum [beta] backports * Disable the machine outliner by default rust-lang#86020 * Fix incorrect gating of nonterminals in key-value attributes rust-lang#85445 * Build crtbegin.o/crtend.o from source code rust-lang#85395 * Bring back x86_64-sun-solaris target to rustup rust-lang#85252 * Preserve SyntaxContext for invalid/dummy spans in crate metadata rust-lang#85211 * [beta] backport: Remove unsound TrustedRandomAccess implementations rust-lang#86222 r? `@Mark-Simulacrum`
Mark-Simulacrum
commented
Jun 17, 2021
Member
Merged as part of #86225 |
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 20, 2021
[beta] Remove unsound TrustedRandomAccess implementations This re-applies rust-lang#86222 for 1.54, as the larger fixes in rust-lang#85874 are still in progress.
GuillaumeGomez added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Jul 22, 2021
…on_only_regression_fix, r=cuviper Regression fix to avoid further beta backports: Remove unsound TrustedRandomAccess implementations Removes the implementations that depend on the user-definable trait `Copy`. Only fix regressions to ensure merge in 1.55: Does not modify `vec::IntoIter`. <hr> This PR applies the beta-`1.53` backport rust-lang#86222 (merged as part of rust-lang#86225), a reduced version of rust-lang#85874 that only fixes regressions, to `master` in order to avoid the need for further backports from `1.55` onwards. Beta-`1.54` backport already happened with rust-lang#87136. In case that rust-lang#85874 gets merged quickly (within a week), this PR would be unnecessary. r? `@cuviper`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Beta backport of #85874, but just for
vec_dequeandarray, as discussed in this meeting (archive, hackmd).