Skip to content

Specify the kind of the item for E0121 - #86223

Merged
bors merged 3 commits into
rust-lang:masterfrom
fee1-dead-contrib:better-E0121
Jun 23, 2021
Merged

Specify the kind of the item for E0121#86223
bors merged 3 commits into
rust-lang:masterfrom
fee1-dead-contrib:better-E0121

Conversation

@fee1-dead

@fee1-deadfee1-dead commented Jun 11, 2021

Copy link
Copy Markdown
Member

Fixes#86005

@rust-highfive

rust-highfive commented Jun 11, 2021

Copy link
Copy Markdown
Contributor

r? @petrochenkov

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 11, 2021
petrochenkov
petrochenkov reviewed Jun 11, 2021
View reviewed changes
Comment threadsrc/test/ui/did_you_mean/bad-assoc-ty.stderr Outdated
Comment threadcompiler/rustc_typeck/src/collect.rs Outdated
@petrochenkovpetrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 11, 2021
@fee1-dead

fee1-dead commented Jun 12, 2021

Copy link
Copy Markdown
MemberAuthor

@rustbot label -S-waiting-on-author S-waiting-on-review

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 12, 2021
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@fee1-dead

fee1-dead commented Jun 13, 2021

Copy link
Copy Markdown
MemberAuthor

mingw-check has timed out. Force pushing amend commit with no changes to retrigger CI.

@bors

This comment has been minimized.

Sign in to view
@fee1-dead

fee1-dead commented Jun 18, 2021•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

I have split the single commit into two, because a lot of the changes were in ui tests and not in compiler/rustc_*.

The diff of the first commit can be easier to review.

@petrochenkov

petrochenkov commented Jun 20, 2021

Copy link
Copy Markdown
Contributor

Seems fine.
@bors r+

@bors

bors commented Jun 20, 2021

Copy link
Copy Markdown
Collaborator

📌 Commit 6d99f54 has been approved by petrochenkov

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 20, 2021
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Jun 21, 2021
@JohnTitor
Rollup merge ofrust-lang#86223- fee1-dead:better-E0121, r=petrochenkov
e972385
Specify the kind of the item for E0121
Fixesrust-lang#86005
@JohnTitorJohnTitor mentioned this pull request Jun 21, 2021
Closed
@fee1-dead

fee1-dead commented Jun 21, 2021•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

@bors r=petrochenkov

I only added a commit to fix builds after #83739.

(I wanted to see if I have the rights :p)

cc @petrochenkov
@rustbot label -S-waiting-on-bors S-waiting-on-review

@bors

bors commented Jun 21, 2021

Copy link
Copy Markdown
Collaborator

@fee1-dead: 🔑 Insufficient privileges: Not in reviewers

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 21, 2021
@petrochenkov

petrochenkov commented Jun 21, 2021

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented Jun 21, 2021

Copy link
Copy Markdown
Collaborator

📌 Commit e66f241 has been approved by petrochenkov

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 21, 2021
fee1-dead added a commit to fee1-dead-contrib/rust that referenced this pull request Jun 22, 2021
@fee1-dead
Rollup merge ofrust-lang#86223- fee1-dead:better-E0121, r=petrochenkov
4e1e6d8
Specify the kind of the item for E0121
Fixesrust-lang#86005
@fee1-deadfee1-dead mentioned this pull request Jun 22, 2021
Closed
@Dylan-DPC-zzDylan-DPC-zz mentioned this pull request Jun 22, 2021
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 22, 2021
@bors
Auto merge ofrust-lang#86559- Dylan-DPC:rollup-aixg3q5, r=Dylan-DPC
574c9dd
Rollup of 6 pull requests
Successful merges:
- rust-lang#86223 (Specify the kind of the item for E0121)
- rust-lang#86521 (Add comments around code where ordering is important due for panic-safety)
- rust-lang#86523 (Improvements to intra-doc link macro disambiguators)
- rust-lang#86542 (Line numbers aligned with content)
- rust-lang#86549 (Add destructuring example of E0508)
- rust-lang#86557 (Update books)
Failed merges:
- rust-lang#86548 (Fix crate filter search reset)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit af9e5d1 into rust-lang:masterJun 23, 2021
@rustbotrustbot added this to the 1.55.0 milestone Jun 23, 2021
@fee1-dead
fee1-dead deleted the better-E0121 branch July 19, 2024 09:24
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@petrochenkovpetrochenkovpetrochenkov approved these changes

Assignees

@petrochenkovpetrochenkov

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

1.55.0

Development

Successfully merging this pull request may close these issues.

The meaning of an "item" in E0121 should be elaborated on

6 participants

@fee1-dead@rust-highfive@rust-log-analyzer@bors@petrochenkov@rustbot