Trait upcasting coercion (part1) by crlf0710 · Pull Request #86264 · rust-lang/rust

crlf0710 · 2021-06-13T11:15:02Z

This revives the first part of earlier PR #60900 .

It's not very clear to me which parts of that pr was design decisions, so i decide to cut it into pieces and land them incrementally. This allows more eyes on the details.

This is the first part, it adds feature gates, adds feature gates tests, and implemented the unsize conversion part.
(I hope i have dealt with the ExistentialTraitRef values correctly...)

The next part will be implementing the pointer casting.

rust-highfive · 2021-06-13T11:15:05Z

r? @petrochenkov

(rust-highfive has picked a reviewer for you, use r? to override)

petrochenkov · 2021-06-13T19:14:14Z

r? @nikomatsakis to clarify on #60900 (comment)
(I'm also not familiar with trait selection etc.)

bors · 2021-06-29T05:32:33Z

☔ The latest upstream changes (presumably #86446) made this pull request unmergeable. Please resolve the merge conflicts.

crlf0710 · 2021-07-09T02:55:43Z

I'd like this to wait on #86461 first.

bors · 2021-07-17T00:49:18Z

☔ The latest upstream changes (presumably #83898) made this pull request unmergeable. Please resolve the merge conflicts.

crlf0710 · 2021-07-25T15:06:06Z

This is ready for review now.

bors · 2021-07-30T14:45:31Z

☔ The latest upstream changes (presumably #87237) made this pull request unmergeable. Please resolve the merge conflicts.

crlf0710 · 2021-07-30T17:40:50Z

Tests added with small tweaking on the second group.
@bors r=nikomatsakis

bors · 2021-07-30T17:40:51Z

📌 Commit d60ae35deaaee047ef186c6538bf06f198cb7cbe has been approved by nikomatsakis

bors · 2021-07-30T22:53:10Z

⌛ Testing commit d60ae35deaaee047ef186c6538bf06f198cb7cbe with merge c7e6df822218f6405f46012092b8f4de4840228d...

bors · 2021-07-30T23:18:07Z

💔 Test failed - checks-actions

crlf0710 · 2021-07-31T02:43:50Z

Added // ignore-compare-mode-nll annotations because the error output is not exactly the same

crlf0710 · 2021-07-31T03:19:42Z

@bors r=nikomatsakis

bors · 2021-07-31T03:19:43Z

📌 Commit a28ee25 has been approved by nikomatsakis

bors · 2021-07-31T07:46:19Z

⌛ Testing commit a28ee25 with merge 7069a8c...

bors · 2021-07-31T10:06:44Z

☀️ Test successful - checks-actions
Approved by: nikomatsakis
Pushing 7069a8c to master...

Trait upcasting coercion (part2) This is the second part of trait upcasting coercion implementation. Currently this is blocked on rust-lang#86264 . The third part might be implemented using unsafety checking r? `@bjorn3`

crlf0710 added the F-trait_upcasting `#![feature(trait_upcasting)]` label Jun 13, 2021

rust-highfive assigned petrochenkov Jun 13, 2021

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 13, 2021

This comment has been minimized.
Sign in to view

crlf0710 force-pushed the trait_upcasting_part1 branch from af39d0f to 4965666Compare June 13, 2021 12:36

rust-highfive assigned nikomatsakis and unassigned petrochenkov Jun 13, 2021

crlf0710 mentioned this pull request Jun 14, 2021
Tracking issue for dyn upcasting coercion #65991
Closed
21 tasks

nikomatsakis reviewed Jun 23, 2021
View reviewed changes

Comment threadcompiler/rustc_trait_selection/src/traits/select/candidate_assembly.rs Outdated
Comment threadcompiler/rustc_trait_selection/src/traits/select/candidate_assembly.rs Outdated

crlf0710 force-pushed the trait_upcasting_part1 branch from 4965666 to c2c6bb7Compare June 27, 2021 19:43

This comment has been minimized.
Sign in to view

crlf0710 force-pushed the trait_upcasting_part1 branch from c2c6bb7 to 2f0db91Compare June 28, 2021 01:19

crlf0710 added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 28, 2021

jonas-schievink mentioned this pull request Jun 30, 2021
get type id from the trait object #85314
Closed

crlf0710 force-pushed the trait_upcasting_part1 branch from 2f0db91 to 4b7453dCompare June 30, 2021 20:28

This comment has been minimized.
Sign in to view

crlf0710 added S-blocked Status: Blocked on something else such as an RFC or other implementation work. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 9, 2021

crlf0710 force-pushed the trait_upcasting_part1 branch from 4b7453d to eff21b2Compare July 25, 2021 14:47

crlf0710 added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-blocked Status: Blocked on something else such as an RFC or other implementation work. labels Jul 25, 2021

This comment has been minimized.
Sign in to view

crlf0710 force-pushed the trait_upcasting_part1 branch from eff21b2 to a9ed43aCompare July 25, 2021 15:10

Alexander Regueiroand others added 3 commits July 31, 2021 00:51

Added feature gate.
2dc86a6

Add feature gate tests.
ac354cf

Implement trait upcasting coercion type-checking.
fb4e0a0

crlf0710 force-pushed the trait_upcasting_part1 branch from 9e4a529 to d60ae35Compare July 30, 2021 16:53

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 30, 2021

This comment has been minimized.
Sign in to view

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 30, 2021

Add more tests to cover more corner cases of type-checking.
a28ee25

crlf0710 force-pushed the trait_upcasting_part1 branch from d60ae35 to a28ee25Compare July 31, 2021 02:42

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 31, 2021

bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 31, 2021

bors merged commit 7069a8c into rust-lang:masterJul 31, 2021

rustbot added this to the 1.56.0 milestone Jul 31, 2021

ehuss mentioned this pull request Jan 27, 2026
Reference updates for forbidding object lifetime changing pointer casts rust-lang/reference#1951
Merged

Uh oh!

Uh oh!

Conversation

crlf0710 commented Jun 13, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rust-highfive commented Jun 13, 2021

Uh oh!

This comment has been minimized.

petrochenkov commented Jun 13, 2021

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

bors commented Jun 29, 2021

Uh oh!

This comment has been minimized.

crlf0710 commented Jul 9, 2021

Uh oh!

bors commented Jul 17, 2021

Uh oh!

This comment has been minimized.

crlf0710 commented Jul 25, 2021

Uh oh!

bors commented Jul 30, 2021

Uh oh!

crlf0710 commented Jul 30, 2021

Uh oh!

bors commented Jul 30, 2021

Uh oh!

bors commented Jul 30, 2021

Uh oh!

This comment has been minimized.

bors commented Jul 30, 2021

Uh oh!

crlf0710 commented Jul 31, 2021

Uh oh!

crlf0710 commented Jul 31, 2021

Uh oh!

bors commented Jul 31, 2021

Uh oh!

bors commented Jul 31, 2021

Uh oh!

bors commented Jul 31, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

crlf0710 commented Jun 13, 2021•
edited
Loading