Skip to content

Don't mark "safe" intrinsics as unsafe - #86327

Merged
bors merged 2 commits into
rust-lang:masterfrom
GuillaumeGomez:safe-intrinsics
Jun 16, 2021
Merged

Don't mark "safe" intrinsics as unsafe#86327
bors merged 2 commits into
rust-lang:masterfrom
GuillaumeGomez:safe-intrinsics

Conversation

@GuillaumeGomez

@GuillaumeGomezGuillaumeGomez commented Jun 15, 2021•
edited
Loading

Copy link
Copy Markdown
Member

A good example of this is intrinsics::abort.

Before:

Screenshot from 2021-06-15 14-58-42

After:

Screenshot from 2021-06-15 14-59-22

cc @jyn514
r? @lqd

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 15, 2021
@jyn514

jyn514 commented Jun 15, 2021

Copy link
Copy Markdown
Member

Can you add a test for this?

@GuillaumeGomez

GuillaumeGomez commented Jun 15, 2021

Copy link
Copy Markdown
MemberAuthor

Well, I have no idea how to do that... Only a few specific intrinsics listed in the typeck function are safe to call, and we don't run DOM tests on std/core. If you have an idea by any chance?

@jyn514

jyn514 commented Jun 15, 2021

Copy link
Copy Markdown
Member

I thought intrinsics were part of the compiler, not the standard library?

Anyway, you can replicate however the standard library does it in a standalone file with #![no_core] and then test that.

@GuillaumeGomez

GuillaumeGomez commented Jun 15, 2021

Copy link
Copy Markdown
MemberAuthor

Oh good idea!

@GuillaumeGomez

GuillaumeGomez commented Jun 15, 2021

Copy link
Copy Markdown
MemberAuthor

Done, thanks again for the tip!

@lqd

lqd commented Jun 15, 2021

Copy link
Copy Markdown
Member

Nicely done. The test is exactly what I was hoping for (thanks @jyn514).

Thanks for taking care of it so quickly !
@bors r+

@bors

bors commented Jun 15, 2021

Copy link
Copy Markdown
Collaborator

📌 Commit 58617eb492a72efb581884f48565a2e7e8c2dcfe has been approved by lqd

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 15, 2021
@lqdlqd mentioned this pull request Jun 15, 2021
Merged
bjorn3
bjorn3 reviewed Jun 15, 2021
View reviewed changes
Comment threadsrc/librustdoc/clean/mod.rs Outdated
@lqd

lqd commented Jun 15, 2021

Copy link
Copy Markdown
Member

@bors r- until we check whether this is applied to all hir::ForeignItem and not just the intrinsics ?

@borsbors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 15, 2021
@GuillaumeGomez

GuillaumeGomez commented Jun 15, 2021

Copy link
Copy Markdown
MemberAuthor

I added the abi check.

@lqd

lqd commented Jun 15, 2021

Copy link
Copy Markdown
Member

Could we add something like this to the test ? core::intrinsics::needs_drop is safe as well

extern"C"{// @has 'foo/fn.needs_drop.html'// @has - '//pre[@class="rust fn"]' 'pub unsafe extern "C" fn needs_drop() -> !'pubfnneeds_drop() -> !;}

@GuillaumeGomez

GuillaumeGomez commented Jun 15, 2021

Copy link
Copy Markdown
MemberAuthor

@lqd Added your test as well!

@lqd

lqd commented Jun 15, 2021

Copy link
Copy Markdown
Member

@bors r+

@bors

bors commented Jun 15, 2021

Copy link
Copy Markdown
Collaborator

📌 Commit f683040 has been approved by lqd

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 15, 2021
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Jun 16, 2021
@Dylan-DPC
Rollup merge ofrust-lang#86327- GuillaumeGomez:safe-intrinsics, r=lqd
6febc97
Don't mark "safe" intrinsics as unsafe
A good example of this is [intrinsics::abort](https://doc.rust-lang.org/nightly/core/intrinsics/fn.abort.html).
Before:
![Screenshot from 2021-06-15 14-58-42](https://user-images.githubusercontent.com/3050060/122056942-65ddad00-cdea-11eb-829e-5f5e258387de.png)
After:
![Screenshot from 2021-06-15 14-59-22](https://user-images.githubusercontent.com/3050060/122056956-6aa26100-cdea-11eb-94d8-e18b4956cfa4.png)
cc `@jyn514`
r? `@lqd`
@Dylan-DPC-zzDylan-DPC-zz mentioned this pull request Jun 16, 2021
Closed
@JohnTitorJohnTitor mentioned this pull request Jun 16, 2021
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 16, 2021
@bors
Auto merge ofrust-lang#86348- JohnTitor:rollup-o6a6k67, r=JohnTitor
52b2286
Rollup of 8 pull requests
Successful merges:
- rust-lang#85283 (Avoid possible filename collision in coverage tests)
- rust-lang#86200 (Updates `Clone` docs for `Copy` comparison.)
- rust-lang#86209 (fix minor wording/typo issues in core::option docs)
- rust-lang#86242 (rustdoc- dont ICE on `ConstEvaluatable` predicates)
- rust-lang#86280 (Add a regression test for issue-76510)
- rust-lang#86293 (Allow to run only a few GUI tests)
- rust-lang#86327 (Don't mark "safe" intrinsics as unsafe)
- rust-lang#86345 (Remove some duplicate `char` assoc items on RELEASES.md)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 98d5842 into rust-lang:masterJun 16, 2021
@rustbotrustbot added this to the 1.55.0 milestone Jun 16, 2021
@GuillaumeGomez
GuillaumeGomez deleted the safe-intrinsics branch June 16, 2021 08:31
@jyn514jyn514 added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Jun 22, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bjorn3bjorn3bjorn3 left review comments

Assignees

@lqdlqd

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.55.0

Development

Successfully merging this pull request may close these issues.

7 participants

@GuillaumeGomez@jyn514@lqd@bors@bjorn3@rust-highfive@rustbot