Skip to content

Avoid cloning LocalDecls - #86362

Merged
bors merged 1 commit into
rust-lang:masterfrom
ptrojahn:insert_vars_and_temps
Aug 31, 2021
Merged

Avoid cloning LocalDecls#86362
bors merged 1 commit into
rust-lang:masterfrom
ptrojahn:insert_vars_and_temps

Conversation

@ptrojahn

@ptrojahnptrojahn commented Jun 16, 2021

Copy link
Copy Markdown
Contributor

No description provided.

@rust-highfive

rust-highfive commented Jun 16, 2021

Copy link
Copy Markdown
Contributor

r? @matthewjasper

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 16, 2021
@JohnTitor

JohnTitor commented Jul 2, 2021

Copy link
Copy Markdown
Member

In case this is perf-sensitive,
@bors try @rust-timer queue

@rust-timer

rust-timer commented Jul 2, 2021

Copy link
Copy Markdown
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbotrustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 2, 2021
@bors

bors commented Jul 2, 2021

Copy link
Copy Markdown
Collaborator

⌛ Trying commit 52841487e503ffb430d8b79b0cfdeab1e93a569e with merge 52547bf071f62d79d15178ef168074a0a84e30a1...

@bors

bors commented Jul 2, 2021

Copy link
Copy Markdown
Collaborator

☀️ Try build successful - checks-actions
Build commit: 52547bf071f62d79d15178ef168074a0a84e30a1 (52547bf071f62d79d15178ef168074a0a84e30a1)

@rust-timer

rust-timer commented Jul 2, 2021

Copy link
Copy Markdown
Collaborator

Queued 52547bf071f62d79d15178ef168074a0a84e30a1 with parent ce331ee, future comparison URL.

@rust-timer

rust-timer commented Jul 2, 2021

Copy link
Copy Markdown
Collaborator

Finished benchmarking try commit (52547bf071f62d79d15178ef168074a0a84e30a1): comparison url.

Summary: This benchmark run did not return any significant changes.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

@rustbotrustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 2, 2021
@JohnTitor

JohnTitor commented Jul 2, 2021

Copy link
Copy Markdown
Member

Looks like it's perf-insensitive.
@bors rollup=maybe

r? @eddyb as FIXME is yours.

@JohnCSimonJohnCSimon added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 18, 2021
@JohnCSimonJohnCSimon added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 9, 2021
@jackh726

jackh726 commented Aug 22, 2021

Copy link
Copy Markdown
Member

@ptrojahn can you rebase? I'll take the review here. r? @jackh726

@rust-highfiverust-highfive assigned jackh726 and unassigned eddybAug 22, 2021
@jackh726jackh726 added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 22, 2021
@ptrojahn
ptrojahnforce-pushed the insert_vars_and_temps branch from 5284148 to ce6296eCompareAugust 23, 2021 18:21
@ptrojahn

ptrojahn commented Aug 23, 2021

Copy link
Copy Markdown
ContributorAuthor

Didn't see the conflict. Rebased

jackh726
jackh726 requested changes Aug 23, 2021
View reviewed changes
Comment threadcompiler/rustc_mir/src/transform/inline.rs Outdated

@jackh726jackh726Aug 23, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, I don't think "exposing" the internal logic of arg_count + 1.. is all that great. Could you add a new function on Body, drain_vars_and_temps?

@ptrojahnptrojahnAug 31, 2021

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed

@ptrojahn
ptrojahnforce-pushed the insert_vars_and_temps branch from ce6296e to e09ab5fCompareAugust 31, 2021 12:48
@ptrojahn
ptrojahnforce-pushed the insert_vars_and_temps branch from e09ab5f to 7bcc9aeCompareAugust 31, 2021 12:52
@ptrojahn
ptrojahn requested a review from jackh726August 31, 2021 12:55
@jackh726

jackh726 commented Aug 31, 2021

Copy link
Copy Markdown
Member

@bors r+ rollup

@bors

bors commented Aug 31, 2021

Copy link
Copy Markdown
Collaborator

📌 Commit 7bcc9ae has been approved by jackh726

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 31, 2021
@m-ou-sem-ou-se mentioned this pull request Aug 31, 2021
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 31, 2021
@bors
Auto merge ofrust-lang#88535- m-ou-se:rollup-jeusxbo, r=m-ou-se
0a84708
Rollup of 10 pull requests
Successful merges:
- rust-lang#85017 (Add carrying_add, borrowing_sub, widening_mul, carrying_mul methods to integers)
- rust-lang#86362 (Avoid cloning LocalDecls)
- rust-lang#88391 (Fix json tuple struct enum variant )
- rust-lang#88399 (Disallow the aapcs CC on Aarch64)
- rust-lang#88418 (Allow `~const` bounds on trait assoc functions)
- rust-lang#88445 (Clean up the lowering of AST items)
- rust-lang#88495 (Add `TcpStream::set_linger` and `TcpStream::linger`)
- rust-lang#88501 (Use right span in prelude collision suggestions with macros. )
- rust-lang#88504 (Keep turbofish in prelude collision lint.)
- rust-lang#88524 (Remove unnecessary `mut` from udp doctests)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 175c8cb into rust-lang:masterAug 31, 2021
@rustbotrustbot added this to the 1.56.0 milestone Aug 31, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jackh726jackh726Awaiting requested review from jackh726

Assignees

@jackh726jackh726

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

1.56.0

Development

Successfully merging this pull request may close these issues.

10 participants

@ptrojahn@rust-highfive@JohnTitor@rust-timer@bors@jackh726@eddyb@JohnCSimon@matthewjasper@rustbot