Uh oh!
There was an error while loading. Please reload this page.
Rollup of 10 pull requests - #86373
Closed
GuillaumeGomez wants to merge 26 commits into
Closed
Conversation
The "read more" sentence formatted "object safety" as inline code instead of providing a link to more information. This PR adds a link to the Reference about this matter, as well as the page regarding trait objects.
…d Vec To remind people like me who forget about it and send PRs to make them different, and to (probably) get a test failure if the code is changed to no longer uphold it.
Added the --temps-dir option Fixesrust-lang#10971. The new `--temps-dir` option puts intermediate files in a user-specified directory. This provides a fix for the issue where parallel invocations of rustc would overwrite each other's intermediate files. No files are kept in the intermediate directory unless `-C save-temps=yes`. If additional files are specifically requested using `--emit asm,llvm-bc,llvm-ir,obj,metadata,link,dep-info,mir`, these will be put in the output directory rather than the intermediate directory. This is a backward-compatible change, i.e. if `--temps-dir` is not specified, the behavior is the same as before.
Fix span calculation in format strings This pull request fixesrust-lang#86085. The ICE described there is due to an error in the span calculation inside format strings, if the format string is the result of a macro invocation: ```rust fn main() { format!(concat!("abc}")); } ``` currently produces: ``` error: invalid format string: unmatched `}` found --> test.rs:2:17 | 2 | format!(concat!("abc}")); | ^ unmatched `}` in format string ``` which is obviously incorrect. This happens because the span of the entire `concat!()` is combined with the _relative_ location of the unmatched `` `}` `` in the _result_ of the macro invocation (i.e. 4). In rust-lang#86085, this has led to a span that starts or ends in the middle of a multibyte character, but the root cause was the same. This pull request fixes the problem.
…nytm Mention the `Borrow` guarantee on the `Hash` implementations for Arrays and `Vec` To remind people like me who forget about it and send PRs to make them different, and to (probably) get a test failure if the code is changed to no longer uphold it.
…d, r=kennytm Link reference in `dyn` keyword documentation The "read more" sentence formatted "object safety" as inline code instead of providing a link to more information. This PR adds a link to the Reference about this matter, as well as the page regarding trait objects. --- We could also put these links in the very first line (instead of the link to the Book) and in the first paragraph which mentions the "object safe" requirement. Personally, I think it's good to keep the link to the Book up-front as it's more accessible than the Reference.
…s, r=petrochenkov Mention rust-lang#79078 on compatibility notes of 1.52 Closesrust-lang#85854 r? `@petrochenkov`
Do not emit invalid suggestions on multiple mutable borrow errors Fixesrust-lang#85581
…_predicates, r=oli-obk Remove `projection_ty_from_predicates` Fixesrust-lang#86350 r? `@oli-obk`
Remove invalid suggestions for assoc consts on placeholder type error Fixesrust-lang#82158 This also moves some tests to typeck. r? `@estebank`
… r=jsha Add missing backslashes to prevent unwanted backlines in rustdoc HTML Just adding some forgotten backslashes. r? `@jsha`
Typo correction: s/is/its
GuillaumeGomez
commented
Jun 16, 2021
MemberAuthor
@bors: r+ p=10 rollup=never |
bors
commented
Jun 16, 2021
Collaborator
📌 Commit fb4fb21 has been approved by |
bors
commented
Jun 16, 2021
Collaborator
⌛ Testing commit fb4fb21 with merge 7f7e9b0a58eb76307a0120f1b6b3ac2e12cdd50d... |
rust-log-analyzer
commented
Jun 16, 2021
Collaborator
The job Click to see the possible cause of the failure (guessed by this bot) |
GuillaumeGomez
commented
Jun 16, 2021
MemberAuthor
Nothing changed bootstrap or the CI scripts, guess it's a spurious failure... @bors: retry |
bors
commented
Jun 16, 2021
Collaborator
⌛ Testing commit fb4fb21 with merge f9951b4d30aca30e8700582fd06ccd79d5f587bf... |
rust-log-analyzer
commented
Jun 16, 2021
Collaborator
The job Click to see the possible cause of the failure (guessed by this bot) |
bors
commented
Jun 16, 2021
Collaborator
💔 Test failed - checks-actions |
GuillaumeGomez
commented
Jun 16, 2021
MemberAuthor
There is something very wrong here but no idea what... Let's close and see if other PRs hit the same issue... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
Borrowguarantee on theHashimplementations for Arrays andVec#86140 (Mention theBorrowguarantee on theHashimplementations for Arrays andVec)dynkeyword documentation #86141 (Link reference indynkeyword documentation)#[derive]into a regular macro attribute #79078 on compatibility notes of 1.52)projection_ty_from_predicates#86353 (Removeprojection_ty_from_predicates)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup