Uh oh!
There was an error while loading. Please reload this page.
Resolve intra-doc links in summary desc - #86451
Merged
bors merged 2 commits intoJun 22, 2021
Merged
Conversation
Before:  After: 
rust-highfive
commented
Jun 18, 2021
Contributor
r? @CraftSpider (rust-highfive has picked a reviewer for you, use r? to override) |
This comment has been minimized.
This comment has been minimized.
notriddle
commented
Jun 21, 2021
ContributorAuthor
@rustbot label: +A-rustdoc |
CraftSpider
commented
Jun 21, 2021
Contributor
This makes the summaries look much nicer with links, thanks! @bors r+ |
bors
commented
Jun 21, 2021
Collaborator
📌 Commit f67585d has been approved by |
fee1-dead added a commit
to fee1-dead-contrib/rust
that referenced
this pull request
Jun 22, 2021
…oc-link-summary, r=CraftSpider Resolve intra-doc links in summary desc Before:  After: 
JohnTitor added a commit
to JohnTitor/rust
that referenced
this pull request
Jun 22, 2021
…oc-link-summary, r=CraftSpider Resolve intra-doc links in summary desc Before:  After: 
This was referenced Jun 22, 2021
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 22, 2021
Rollup of 6 pull requests Successful merges: - rust-lang#86393 (Add regression test for issue rust-lang#52025) - rust-lang#86402 (rustdoc: add optional woff2 versions of Source Serif and Source Code) - rust-lang#86451 (Resolve intra-doc links in summary desc) - rust-lang#86501 (Cleanup handling of `crate_name` for doctests) - rust-lang#86517 (Fix `unused_unsafe` around `await`) - rust-lang#86537 (Mark some edition tests as check-pass) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
camelid added a commit
to camelid/rust
that referenced
this pull request
Sep 4, 2021
It was accidentally changed to use `opts()` in rust-lang#86451. I also renamed `opts()` to `main_body_opts()` to make this kind of accidental change less likely.
notriddle added a commit
to notriddle/rust
that referenced
this pull request
Feb 16, 2022
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 20, 2022
…-resolve, r=GuillaumeGomez rustdoc: resolve intra-doc links when checking HTML Similar to rust-lang#86451 CC rust-lang#67799 Given this test case: ```rust #![warn(rustdoc::invalid_html_tags)] #![warn(rustdoc::broken_intra_doc_links)] pub struct ExistentStruct<T>(T); /// This [test][ExistentStruct<i32>] thing! pub struct NoError; ``` This pull request silences the following, spurious warning: ```text warning: unclosed HTML tag `i32` --> test.rs:6:31 | 6 | /// This [test][ExistentStruct<i32>] thing! | ^^^^^ | note: the lint level is defined here --> test.rs:1:9 | 1 | #![warn(rustdoc::invalid_html_tags)] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try marking as source code | 6 | /// This [test][`ExistentStruct<i32>`] thing! | + + warning: 1 warning emitted ```
matthiaskrgr added a commit
to matthiaskrgr/rust
that referenced
this pull request
Feb 12, 2023
…-meta-description, r=camelid,GuillaumeGomez rustdoc: account for intra-doc links in `<meta name="description">` Similar to rust-lang#86451, but for the SEO descriptions instead of the search descriptions.
matthiaskrgr added a commit
to matthiaskrgr/rust
that referenced
this pull request
Feb 12, 2023
…-meta-description, r=camelid,GuillaumeGomez rustdoc: account for intra-doc links in `<meta name="description">` Similar to rust-lang#86451, but for the SEO descriptions instead of the search descriptions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before:
After: