Derive Copy for VarianceDiagInfo

[Aaron1011]

No description provided.

[rust-highfive]

r? @davidtwco

(rust-highfive has picked a reviewer for you, use r? to override)

[Aaron1011]

@bors try @rust-timer queue

[rust-timer]

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

[bors]

⌛ Trying commit 4be38d2 with merge 242d9f0318ecad35ad4e410f82bae32fb62fe3d0...

[bors]

☀️ Try build successful - checks-actions
Build commit: 242d9f0318ecad35ad4e410f82bae32fb62fe3d0 (242d9f0318ecad35ad4e410f82bae32fb62fe3d0)

[rust-timer]

Queued 242d9f0318ecad35ad4e410f82bae32fb62fe3d0 with parent 543ab99, future comparison URL.

[rust-timer]

Finished benchmarking try commit (242d9f0318ecad35ad4e410f82bae32fb62fe3d0): comparison url.

Summary: This change led to significant improvements 🎉 in compiler performance.

• Moderate improvement in instruction counts (up to -4.8% on full builds of wg-grammar-check)

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

[rustbot]

Error: Label perf-regression can only be set by Rust team members

Please let @rust-lang/release know if you're having trouble with this bot.

[Aaron1011]

The performance improvements suggest that it might be worth trying to revive #72409 in some form - the compiler shouldn't need a #[derive(Copy)] to perform these kinds of optimizations.

[klensy]

Improvement in one test, but max-rss is red in most cases (given that max-rss bench results accuracy not high and can be scattered up and down).

[davidtwco]

LGTM, r=me if this is something you wanted to land and not just an experiment to check #72409's viability.

[Aaron1011]

This is intended to fix the performance regression caused by adding the variance diag info.

@bors r=davidtwco

[bors]

📌 Commit 4be38d2 has been approved by davidtwco

[bors]

⌛ Testing commit 4be38d2 with merge 71a97b28ab15a7ff758e748e9518088f6adfa076...

[bors]

💔 Test failed - checks-actions

[rust-log-analyzer]

A job failed! Check out the build log: (web)(plain)

Click to see the possible cause of the failure (guessed by this bot)

[Aaron1011]

@bors retry

[bors]

⌛ Testing commit 4be38d2 with merge 47b2f15...

[bors]

☀️ Test successful - checks-actions
Approved by: davidtwco
Pushing 47b2f15 to master...

[pnkfelix]

Thanks @Aaron1011 ! End results look good to me. (Original regressing results here for reference.)