Uh oh!
There was an error while loading. Please reload this page.
Rollup of 6 pull requests - #86690
Merged
Merged
Conversation
…ulacrum Fix type checking of return expressions outside of function bodies This pull request fixesrust-lang#86188. The problem is that the current code for type-checking `return` expressions stops if the `return` occurs outside of a function body, while the correct behavior is to continue type-checking the return value expression (otherwise an ICE happens later on because variables declared in the return value expression don't have a type). Also, I have noticed that it is sometimes not obvious why a `return` is outside of a function body; for instance, in the example from rust-lang#86188 (which currently causes an ICE): ```rust fn main() { [(); return || { let tx; }] } ``` I have changed the error message to also explain why the `return` is considered outside of the function body: ``` error[E0572]: return statement outside of function body --> ice0.rs:2:10 | 1 | / fn main() { 2 | | [(); return || { | |__________^ 3 | || let tx; 4 | || }] | ||_____^ the return is part of this body... 5 | | } | |_- ...not the enclosing function body ```
fix pretty print for `loop`
…lacrum Don't dist miri or rust-analyzer on stable or beta. This prevents miri and rust-analyzer from being built for "dist" or "install" on the stable/beta channels. It is a nightly-only tool and should not be included. Closesrust-lang#86286
…=jonas-schievink ⬆️ rust-analyzer
…Mark-Simulacrum Allow anyone to set `perf-regression` label The main purpose is to allow the triage bot to set the label: rust-lang#86617 (comment) r? `@Mark-Simulacrum`
Add a regression test for issue-65384 Closesrust-lang#65384 r? `@jackh726`
JohnTitor
commented
Jun 28, 2021
MemberAuthor
@bors r+ rollup=never p=6 |
bors
commented
Jun 28, 2021
Collaborator
📌 Commit c5055b7 has been approved by |
bors
commented
Jun 28, 2021
Collaborator
bors
commented
Jun 28, 2021
Collaborator
☀️ Test successful - checks-actions |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
loop#86358 (fix pretty print forloop)perf-regressionlabel #86687 (Allow anyone to setperf-regressionlabel)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup