Uh oh!
There was an error while loading. Please reload this page.
Rollup of 5 pull requests - #87003
Merged
Merged
Conversation
to simplify the implementation and avoid unnecessary conversions from `Option<usize>` to `isize` and back.
I'd updated the ones inside the method, but not its doc comment.
It was already used for the message. This also uses it for the spans used for the error and backtrace.
Fix comments about unique borrows
Inline implementation of lookup_line to avoid unnecessary conversions from `Option<usize>` to `isize` and back.
…, r=nagisa Change linked tracking issue for more_qualified_paths This updates the linked tracking issue for the `more_qualified_paths` feature from the implementation PR rust-lang#80080 to an actual tracking issue rust-lang#86935.
…trochenkov Update the comment on `lower_expr_try` I'd updated the ones inside the method, but not its doc comment.
…=oli-obk Use #[track_caller] in const panic diagnostics. This change stops const panic diagnostics from reporting inside #[track_caller] functions by skipping over them.
m-ou-se
commented
Jul 9, 2021
MemberAuthor
@bors r+ rollup=never p=5 |
bors
commented
Jul 9, 2021
Collaborator
📌 Commit 2152c14 has been approved by |
bors
commented
Jul 9, 2021
Collaborator
bors
commented
Jul 9, 2021
Collaborator
☀️ Test successful - checks-actions |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
lower_expr_try#86994 (Update the comment onlower_expr_try)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup