Skip to content

Shrink the CrateStore dynamic interface. - #87117

Merged
bors merged 1 commit into
rust-lang:masterfrom
cjgillot:cstore
Jul 14, 2021
Merged

Shrink the CrateStore dynamic interface.#87117
bors merged 1 commit into
rust-lang:masterfrom
cjgillot:cstore

Conversation

@cjgillot

@cjgillotcjgillot commented Jul 13, 2021

Copy link
Copy Markdown
Contributor

The information is either accessible through queries or by crates which already depend on rustc_metadata.

@rust-highfive

rust-highfive commented Jul 13, 2021

Copy link
Copy Markdown
Contributor

r? @estebank

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 13, 2021
jyn514
jyn514 reviewed Jul 13, 2021
View reviewed changes
Comment threadcompiler/rustc_middle/src/middle/cstore.rs Outdated
Comment threadcompiler/rustc_middle/src/middle/cstore.rs Outdated
@petrochenkovpetrochenkov self-assigned this Jul 14, 2021
michaelwoerister
michaelwoerister reviewed Jul 14, 2021
View reviewed changes
Comment threadcompiler/rustc_middle/src/query/mod.rs Outdated
cjgillot
cjgillot commented Jul 14, 2021
View reviewed changes
Comment threadcompiler/rustc_middle/src/query/mod.rs Outdated
@petrochenkov

petrochenkov commented Jul 14, 2021

Copy link
Copy Markdown
Contributor

r? @petrochenkov
r=me with commits squashed.

@petrochenkovpetrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 14, 2021
@cjgillot

cjgillot commented Jul 14, 2021

Copy link
Copy Markdown
ContributorAuthor

@bors r=petrochenkov

@bors

bors commented Jul 14, 2021

Copy link
Copy Markdown
Collaborator

📌 Commit 3fba5a4 has been approved by petrochenkov

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 14, 2021
@GuillaumeGomezGuillaumeGomez mentioned this pull request Jul 14, 2021
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 14, 2021
@bors
Auto merge ofrust-lang#87133- GuillaumeGomez:rollup-pfz9jbk, r=Guil…
e87188c
…laumeGomez
Rollup of 6 pull requests
Successful merges:
- rust-lang#87027 (expand: Support helper attributes for built-in derive macros)
- rust-lang#87056 (Fix codeblocks overflow)
- rust-lang#87117 (Shrink the CrateStore dynamic interface.)
- rust-lang#87120 (rustdoc: Remove unnecessary `extern crate` aliases)
- rust-lang#87125 (Fix Ayu theme `<code>` color)
- rust-lang#87130 (Update browser-ui-test package version)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 40155f5 into rust-lang:masterJul 14, 2021
@rustbotrustbot added this to the 1.55.0 milestone Jul 14, 2021
@cjgillot
cjgillot deleted the cstore branch July 15, 2021 11:11
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@michaelwoeristermichaelwoeristermichaelwoerister left review comments
@jyn514jyn514jyn514 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@petrochenkovpetrochenkov

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

1.55.0

Development

Successfully merging this pull request may close these issues.

8 participants

@cjgillot@rust-highfive@petrochenkov@bors@michaelwoerister@jyn514@estebank@rustbot