Uh oh!
There was an error while loading. Please reload this page.
fix typo in compile_fail doctest - #87183
Conversation
rust-highfive
commented
Jul 16, 2021
r? @scottmcm (rust-highfive has picked a reviewer for you, use r? to override) |
tlyu
commented
Jul 16, 2021
Thanks! I would have hoped that the ordinary doctest pass would have caught that, especially given the error code number. |
RalfJung
commented
Jul 16, 2021
I assume the error code number ensures that this error code is present, but does not prevent other errors from also being present. |
jyn514
commented
Jul 17, 2021
@bors r+ rollup It seems unfortunate that Miri gets so confused on name errors, but you're already aware of that and this is a good fix anyway. |
bors
commented
Jul 17, 2021
📌 Commit 0d3d6f0 has been approved by |
RalfJung
commented
Jul 17, 2021
Yes, that is tracked at rust-lang/miri-test-libstd#4. (It's not really a Miri bug, more an unfortunate consequence of rustc's behavior when suggesting alternative names [eagerly loading all the crates it can find], and the hacky way we use to execute libcore doctests without |
fix typo in compile_fail doctest Fixes a typo introduced by rust-lang#86211. For some reason this typo makes Miri go all crazy when running libcore doctests (rust-lang/miri#1852). Kudos to `@hyd-dev` for noticing the typo. Cc `@tlyu` `@joshtriplett`
Rollup of 8 pull requests Successful merges: - rust-lang#86763 (Add a regression test for issue-63355) - rust-lang#86814 (Recover from a misplaced inner doc comment) - rust-lang#86843 (Check that const parameters of trait methods have compatible types) - rust-lang#86889 (rustdoc: Cleanup ExternalCrate) - rust-lang#87092 (Remove nondeterminism in multiple-definitions test) - rust-lang#87170 (Add diagnostic items for Clippy) - rust-lang#87183 (fix typo in compile_fail doctest) - rust-lang#87205 (rustc_middle: remove redundant clone) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Fixes a typo introduced by #86211. For some reason this typo makes Miri go all crazy when running libcore doctests (rust-lang/miri#1852). Kudos to @hyd-dev for noticing the typo.
Cc @tlyu@joshtriplett