Uh oh!
There was an error while loading. Please reload this page.
Don't hide fields of enum struct variants - #87332
Merged
Merged
Conversation
rust-highfive
commented
Jul 21, 2021
Contributor
Some changes occurred in HTML/CSS/JS. |
rust-highfive
commented
Jul 21, 2021
Contributor
(rust-highfive has picked a reviewer for you, use r? to override) |
camelid
commented
Jul 21, 2021
MemberAuthor
ExamplepubenumEnum{Variant1{x:i32,y:String},Variant2(Vec<u32>, std::path::PathBuf),}Output (before)
Output (after)
|
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Can you also check the "DOM path" please? !has doesn't cover changes, only that something doesn't exist after all.
MemberAuthor
There was a problem hiding this comment.
Isn't this current test more general than checking a specific DOM path? I feel a bit confused about what you'd like me to change the test to. Could you give an example of what you mean?
There was a problem hiding this comment.
I was thinking that the <details> tag was wrapping another tag, but this is not the case. I really don't like that but I guess we can't do better.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
* The toggle adds visual clutter * It's easy to miss that there are fields * Tuple variant fields are always shown, so it is inconsistent to hide struct variant fields * It's annoying to have to click the toggle every time
GuillaumeGomez
commented
Jul 22, 2021
Member
Thanks! @bors: r+ |
bors
commented
Jul 22, 2021
Collaborator
📌 Commit 97623bf has been approved by |
JohnTitor added a commit
to JohnTitor/rust
that referenced
this pull request
Jul 23, 2021
…meGomez Don't hide fields of enum struct variants * The toggle adds visual clutter * It's easy to miss that there are fields * Tuple variant fields are always shown, so it is inconsistent to hide struct variant fields * It's annoying to have to click the toggle every time
This was referenced Jul 23, 2021
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 23, 2021
Rollup of 8 pull requests Successful merges: - rust-lang#87034 (DOC: fix hypothetical Rust code in `step_by()` docstring) - rust-lang#87298 (memorialize Anna Harren in the bastion of the turbofish) - rust-lang#87332 (Don't hide fields of enum struct variants) - rust-lang#87362 (Make `x.py d` an alias for `x.py doc`) - rust-lang#87372 (Move calls to test_main into one function) - rust-lang#87373 (Extend HIR WF checking to fields) - rust-lang#87376 (Change rustdoc logo to use the full container size) - rust-lang#87383 (Add regression tests for the impl_trait_in_bindings ICEs) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
struct variant fields