Skip to content

Beta targetted revert 81473 warn write only fields - #87369

Merged
bors merged 2 commits into
rust-lang:betafrom
pnkfelix:beta-targetted-revert-81473-warn-write-only-fields
Jul 23, 2021
Merged

Beta targetted revert 81473 warn write only fields#87369
bors merged 2 commits into
rust-lang:betafrom
pnkfelix:beta-targetted-revert-81473-warn-write-only-fields

Conversation

@pnkfelix

Copy link
Copy Markdown
Contributor

beta backport of PR #86212

Revert "Add missing brace"
This reverts commit 85ad773.
Revert "Simplify base_expr"
This reverts commit 899aae4.
Revert "Warn write-only fields"
This reverts commit d3c69a4.
I expect thi8s method to come back very soon; noise of removing them to satisfy lint seems wrong.
@rust-highfive

Copy link
Copy Markdown
Contributor

r? @matthewjasper

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive

Copy link
Copy Markdown
Contributor

⚠️Warning⚠️

  • Pull requests are usually filed against the master branch for this repo, but this one is against beta. Please double check that you specified the right target!

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 22, 2021
@Mark-Simulacrum

Copy link
Copy Markdown
Member

@bors r+ rollup=never p=1

@bors

bors commented Jul 22, 2021

Copy link
Copy Markdown
Collaborator

📌 Commit e541354 has been approved by Mark-Simulacrum

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 22, 2021
@bors

bors commented Jul 22, 2021

Copy link
Copy Markdown
Collaborator

⌛ Testing commit e541354 with merge 20e7d35e878e98a46ff0213eec6c785345068700...

@rust-log-analyzer

Copy link
Copy Markdown
Collaborator

The job aarch64-gnu failed! Check out the build log: (web)(plain)

Click to see the possible cause of the failure (guessed by this bot)

failures:
---- thread::local::tests::join_orders_after_tls_destructors stdout ----
thread 'thread::local::tests::join_orders_after_tls_destructors' panicked at 'internal error: entered unreachable code: sync state: Err(2)', library/std/src/thread/local/tests.rs:312:22
failures:
thread::local::tests::join_orders_after_tls_destructors
test result: FAILED. 859 passed; 1 failed; 1 ignored; 0 measured; 0 filtered out; finished in 10.35s
error: test failed, to rerun pass '-p std --lib'
command did not execute successfully: "/checkout/obj/build/aarch64-unknown-linux-gnu/stage0/bin/cargo" "test" "--target" "aarch64-unknown-linux-gnu" "-Zbinary-dep-depinfo" "-j" "14" "--release" "--locked" "--color" "always" "--features" "panic-unwind backtrace profiler compiler-builtins-c" "--manifest-path" "/checkout/library/test/Cargo.toml" "-p" "std" "--"
failed to run: /checkout/obj/build/bootstrap/debug/bootstrap --stage 2 test
Build completed unsuccessfully in 0:26:39

@bors

bors commented Jul 22, 2021

Copy link
Copy Markdown
Collaborator

💔 Test failed - checks-actions

@borsbors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 22, 2021
@Mark-Simulacrum

Copy link
Copy Markdown
Member

@bors retry

thread 'thread::local::tests::join_orders_after_tls_destructors' panicked at 'internal error: entered unreachable code: sync state: Err(2)', library/std/src/thread/local/tests.rs:312:22

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 22, 2021
@bors

bors commented Jul 23, 2021

Copy link
Copy Markdown
Collaborator

⌛ Testing commit e541354 with merge b959328...

@bors

bors commented Jul 23, 2021

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing b959328 to beta...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Jul 23, 2021
@bors
bors merged commit b959328 into rust-lang:betaJul 23, 2021
@rustbotrustbot added this to the 1.54.0 milestone Jul 23, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-by-borsThis PR was explicitly merged by bors.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@pnkfelix@rust-highfive@Mark-Simulacrum@bors@rust-log-analyzer@matthewjasper@rustbot