Skip to content

Point to where clause for GATs to add bound - #87478

Merged
bors merged 1 commit into
rust-lang:masterfrom
jackh726:issue-84931
Aug 14, 2021
Merged

Point to where clause for GATs to add bound#87478
bors merged 1 commit into
rust-lang:masterfrom
jackh726:issue-84931

Conversation

@jackh726

@jackh726jackh726 commented Jul 26, 2021

Copy link
Copy Markdown
Member

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 26, 2021
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
lqd
lqd reviewed Jul 26, 2021
View reviewed changes
Comment threadcompiler/rustc_driver/src/lib.rs Outdated
@bors

bors commented Aug 12, 2021

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #87948) made this pull request unmergeable. Please resolve the merge conflicts.

estebank
estebank reviewed Aug 12, 2021
View reviewed changes
Comment threadcompiler/rustc_infer/src/infer/error_reporting/mod.rs Outdated

@estebankestebankAug 12, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make the suggestion a bit easier to read, given that it points at a span right in the middle of a larger span:

Suggested change
err.span_suggestion(
err.span_suggestion_verbose(

@estebankestebankAug 12, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although that would require rewording the other span label...

@estebankestebankAug 12, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I leave it to your decision what to do here.

@jackh726jackh726Aug 13, 2021

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, now that the associated type points to the type itself, not the whole defintion, they don't overlap anymore.

I do think the verbose suggestion would be nice, but I'll leave that as a followup.

estebank
estebank reviewed Aug 12, 2021
View reviewed changes
Comment threadsrc/test/ui/generic-associated-types/issue-86787.rs Outdated

@estebankestebankAug 12, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we mark the tests // run-rustfix?

@jackh726jackh726Aug 13, 2021

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So...no. The suggestion here doesn't actually result in code that compiles, because it causes the where clauses not to match the trait's where clauses. (In fact, in this case, we can't write this where clause in the trait, we would have to use Self)

Unfortunately, that's a whole separate issue with GATs. But applying the current suggestion should help, in the future, to guide the user towards matching the trait's where clauses.

@estebank

estebank commented Aug 12, 2021

Copy link
Copy Markdown
Contributor

r=me after cleaning up the commented out code.

@jackh726

jackh726 commented Aug 13, 2021

Copy link
Copy Markdown
MemberAuthor

@bors r=estebank

@bors

bors commented Aug 13, 2021

Copy link
Copy Markdown
Collaborator

📌 Commit 22fc7d6 has been approved by estebank

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 13, 2021
@bors

bors commented Aug 13, 2021

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 22fc7d6 with merge d0a10b2...

@bors

bors commented Aug 14, 2021

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions
Approved by: estebank
Pushing d0a10b2 to master...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Aug 14, 2021
@bors
bors merged commit d0a10b2 into rust-lang:masterAug 14, 2021
@rustbotrustbot added this to the 1.56.0 milestone Aug 14, 2021
@jackh726
jackh726 deleted the issue-84931 branch August 14, 2021 01:17
@jackh726
jackh726 restored the issue-84931 branch March 12, 2022 18:30
@jackh726
jackh726 deleted the issue-84931 branch March 12, 2022 18:35
@jackh726
jackh726 restored the issue-84931 branch March 12, 2022 18:42
@jackh726
jackh726 deleted the issue-84931 branch March 12, 2022 18:52
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lqdlqdlqd left review comments
@estebankestebankestebank left review comments

Assignees

@estebankestebank

Labels

merged-by-borsThis PR was explicitly merged by bors.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

1.56.0

Development

Successfully merging this pull request may close these issues.

GAT: confusing diagnostic when missing where clause

7 participants

@jackh726@rust-log-analyzer@bors@estebank@lqd@rust-highfive@rustbot