Skip to content

rfc3052 followup: Remove authors field from Cargo manifests - #87535

Merged
bors merged 1 commit into
rust-lang:masterfrom
lf-:authors
Aug 2, 2021
Merged

rfc3052 followup: Remove authors field from Cargo manifests#87535
bors merged 1 commit into
rust-lang:masterfrom
lf-:authors

Conversation

@lf-

@lf-lf- commented Jul 28, 2021

Copy link
Copy Markdown
Contributor

Since RFC 3052 soft deprecated the authors field, hiding it from
crates.io, docs.rs, and making Cargo not add it by default, and it is
not generally up to date/useful information for contributors, we may as well
remove it from crates in this repo.

@rust-highfive

rust-highfive commented Jul 28, 2021

Copy link
Copy Markdown
Contributor

Some changes occurred in src/tools/clippy.

cc @rust-lang/clippy

Some changes occurred in src/tools/rustfmt.

cc @calebcartwright

Some changes occured to rustc_codegen_cranelift

cc @bjorn3

rustdoc-json-types is a public (although nightly-only) API. Consider changing src/librustdoc/json/conversions.rs instead; otherwise, make sure you update format_version.

cc @CraftSpider,@aDotInTheVoid

Changes rustc_apfloat. rustc_apfloat is currently in limbo and you almost certainly don't want to change it (see #55993).

cc @eddyb

@rust-highfive

rust-highfive commented Jul 28, 2021

Copy link
Copy Markdown
Contributor

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 28, 2021
eddyb
eddyb reviewed Jul 28, 2021
View reviewed changes
Comment threadcompiler/rustc_apfloat/Cargo.toml Outdated
@bors

bors commented Jul 29, 2021

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #87579) made this pull request unmergeable. Please resolve the merge conflicts.

@lf-
rfc3052: Remove authors field from Cargo manifests
3cf820e
Since RFC 3052 soft deprecated the authors field anyway, hiding it from
crates.io, docs.rs, and making Cargo not add it by default, and it is
not generally up to date/useful information, we should remove it from
crates in this repo.
@Mark-Simulacrum

Mark-Simulacrum commented Aug 1, 2021

Copy link
Copy Markdown
Member

@bors r+

I think this is a reasonable step to take, thanks!

@bors

bors commented Aug 1, 2021

Copy link
Copy Markdown
Collaborator

📌 Commit 3cf820e has been approved by Mark-Simulacrum

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 1, 2021
@bors

bors commented Aug 2, 2021

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 3cf820e with merge b53a93d...

@bors

bors commented Aug 2, 2021

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing b53a93d to master...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Aug 2, 2021
@bors
bors merged commit b53a93d into rust-lang:masterAug 2, 2021
@rustbotrustbot added this to the 1.56.0 milestone Aug 2, 2021
This was referenced Aug 2, 2021
Closed
Closed
Merged
flip1995 pushed a commit to flip1995/rust that referenced this pull request Aug 12, 2021
@bors
Auto merge ofrust-lang#87535- lf-:authors, r=Mark-Simulacrum
10bb28c
rfc3052 followup: Remove authors field from Cargo manifests
Since RFC 3052 soft deprecated the authors field, hiding it from
crates.io, docs.rs, and making Cargo not add it by default, and it is
not generally up to date/useful information for contributors, we may as well
remove it from crates in this repo.
calebcartwright pushed a commit to calebcartwright/rust that referenced this pull request Oct 20, 2021
@bors
Auto merge ofrust-lang#87535- lf-:authors, r=Mark-Simulacrum
2323cbc
rfc3052 followup: Remove authors field from Cargo manifests
Since RFC 3052 soft deprecated the authors field, hiding it from
crates.io, docs.rs, and making Cargo not add it by default, and it is
not generally up to date/useful information for contributors, we may as well
remove it from crates in this repo.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@eddybeddybeddyb left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@Mark-SimulacrumMark-Simulacrum

Labels

merged-by-borsThis PR was explicitly merged by bors.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

1.56.0

Development

Successfully merging this pull request may close these issues.

6 participants

@lf-@rust-highfive@bors@Mark-Simulacrum@eddyb@rustbot