Uh oh!
There was an error while loading. Please reload this page.
Add missing examples for NonNull - #87547
Merged
Merged
Conversation
rust-highfive
commented
Jul 28, 2021
Contributor
r? @kennytm (rust-highfive has picked a reviewer for you, use r? to override) |
GuillaumeGomezforce-pushed
the
nonnull-examples
branch
from
July 28, 2021 13:16
6cf5fc8 to
8f7dba8Comparekennytm
reviewed
Jul 30, 2021
Uh oh!
There was an error while loading. Please reload this page.
GuillaumeGomezforce-pushed
the
nonnull-examples
branch
from
July 30, 2021 08:02
8f7dba8 to
4ace7e7CompareGuillaumeGomez
commented
Jul 30, 2021
MemberAuthor
Updated! |
This comment has been minimized.
This comment has been minimized.
GuillaumeGomezforce-pushed
the
nonnull-examples
branch
from
July 30, 2021 09:04
4ace7e7 to
cfe9858Compare
This comment has been minimized.
This comment has been minimized.
GuillaumeGomezforce-pushed
the
nonnull-examples
branch
from
July 30, 2021 09:30
cfe9858 to
1bbe618CompareGuillaumeGomez
commented
Jul 30, 2021
MemberAuthor
@bors: r=kennytm rollup |
bors
commented
Jul 30, 2021
Collaborator
📌 Commit 1bbe618 has been approved by |
JohnTitor added a commit
to JohnTitor/rust
that referenced
this pull request
Jul 30, 2021
…kennytm Add missing examples for NonNull
This was referenced Jul 30, 2021
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 30, 2021
Rollup of 9 pull requests Successful merges: - rust-lang#86072 (Cross compiling rustc_llvm on Darwin requires zlib.) - rust-lang#87385 (Make `SEMICOLON_IN_EXPRESSIONS_FROM_MACROS` warn by default) - rust-lang#87547 (Add missing examples for NonNull) - rust-lang#87557 (Fix issue with autofix for ambiguous associated function from Rust 2021 prelude when struct is generic) - rust-lang#87559 (Tweak borrowing suggestion in `for` loop) - rust-lang#87596 (Add warning when whitespace is not skipped after an escaped newline) - rust-lang#87606 (Add some TAIT-related regression tests) - rust-lang#87609 (Add docs about performance and `Iterator::map` to `[T; N]::map`) - rust-lang#87616 (Fix missing word in rustdoc book) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
| /// let ptr = unsafe { NonNull::new_unchecked(&mut x as *mut _) }; | ||
| /// | ||
| /// // NEVER DO THAT!!! | ||
| /// let ptr = unsafe { NonNull::<u32>::new_unchecked(std::ptr::null_mut()) }; |
Member
There was a problem hiding this comment.
Please mark testcases that cause UB as no_run (see e.g. the MaybeUninit docs).
Otherwise, https://github.com/rust-lang/miri-test-libstd/ will fail.
JohnTitor added a commit
to JohnTitor/rust
that referenced
this pull request
Aug 2, 2021
mark a UB doctest as no_run See rust-lang#87547 (comment) Cc `@GuillaumeGomez` `@kennytm`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.