Uh oh!
There was an error while loading. Please reload this page.
Add documentation for the order of Option and Result - #87654
Merged
Conversation
rust-highfive
commented
Jul 31, 2021
Contributor
(rust-highfive has picked a reviewer for you, use r? to override) |
scottmcm
commented
Jul 31, 2021
Member
It's not obvious to me that the manual implementation is worth it, here. There's also something to be said for people seeing that it's just the derived one. Adding documentation (and doctests) about it is definitely good, though. Maybe, as a compromise, add another section to the module level docs about how Ord/Eq/Hash/etc work with it? There are a bunch that were added recently, and this feels like it would fit that pattern well. |
jesyspa
marked this pull request as draft
July 31, 2021 21:21
jesyspa
commented
Jul 31, 2021
ContributorAuthor
Thanks, that makes sense, let me write it up there :) |
jesyspaforce-pushed
the
issue-87238-option-result-doc
branch
from
August 1, 2021 11:21
05c53cc to
60ddd6bComparejesyspaforce-pushed
the
issue-87238-option-result-doc
branch
from
August 1, 2021 11:59
7fe3e07 to
40eaab1Comparejesyspa
marked this pull request as ready for review
August 1, 2021 12:00
scottmcm
commented
Aug 2, 2021
Member
bors
commented
Aug 2, 2021
Collaborator
📌 Commit 40eaab1 has been approved by |
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 2, 2021
Rollup of 6 pull requests Successful merges: - rust-lang#86176 (Implement a `explicit_generic_args_with_impl_trait` feature gate) - rust-lang#87654 (Add documentation for the order of Option and Result) - rust-lang#87659 (Fix invalid suggestions for non-ASCII characters in byte constants) - rust-lang#87673 (Tweak opaque type mismatch error) - rust-lang#87687 (Inline some macros) - rust-lang#87690 (Add missing "allocated object" doc link to `<*mut T>::add`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This resolves issue #87238.