Skip to content

Improve error reporting for closure return type mismatches - #87661

Merged
bors merged 1 commit into
rust-lang:masterfrom
FabianWolff:issue-87461
Aug 23, 2021
Merged

Improve error reporting for closure return type mismatches#87661
bors merged 1 commit into
rust-lang:masterfrom
FabianWolff:issue-87461

Conversation

@FabianWolff

@FabianWolffFabianWolff commented Jul 31, 2021

Copy link
Copy Markdown
Contributor

Fixes#87461.

@rust-highfive

rust-highfive commented Jul 31, 2021

Copy link
Copy Markdown
Contributor

r? @wesleywiser

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 31, 2021
@JohnCSimonJohnCSimon added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 15, 2021
wesleywiser
wesleywiser approved these changes Aug 20, 2021
View reviewed changes

@wesleywiserwesleywiser left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks fine to me but I'm not sure about the interaction with existing diagnostics. Most of the changed UI tests seem like they have useful notes to me.

@wesleywiser

wesleywiser commented Aug 20, 2021

Copy link
Copy Markdown
Member

r? @estebank

I'm ok with merging this if the changes in diagnostics look good to you.

@FabianWolff

FabianWolff commented Aug 20, 2021

Copy link
Copy Markdown
ContributorAuthor

The code looks fine to me but I'm not sure about the interaction with existing diagnostics. Most of the changed UI tests seem like they have useful notes to me.

Yes, you are completely right @wesleywiser; I don't remember why I thought it would be OK for these notes to disappear. I have reworked my implementation so that it now works for all existing test cases.

@estebank

estebank commented Aug 23, 2021

Copy link
Copy Markdown
Contributor

I don't know what the previous code looked like, but I'm ok with this.

@bors r+

@bors

bors commented Aug 23, 2021

Copy link
Copy Markdown
Collaborator

📌 Commit d2fe289 has been approved by estebank

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 23, 2021
@bors

bors commented Aug 23, 2021

Copy link
Copy Markdown
Collaborator

⌛ Testing commit d2fe289 with merge 52c881f...

@bors

bors commented Aug 23, 2021

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions
Approved by: estebank
Pushing 52c881f to master...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Aug 23, 2021
@bors
bors merged commit 52c881f into rust-lang:masterAug 23, 2021
@rustbotrustbot added this to the 1.56.0 milestone Aug 23, 2021
@borsbors mentioned this pull request Aug 23, 2021
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wesleywiserwesleywiserAwaiting requested review from wesleywiser

Assignees

@estebankestebank

Labels

merged-by-borsThis PR was explicitly merged by bors.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

1.56.0

Development

Successfully merging this pull request may close these issues.

return-type mismatch in async function gives "return type inferred" pointing to use of ?

7 participants

@FabianWolff@rust-highfive@wesleywiser@estebank@bors@JohnCSimon@rustbot