Skip to content

Adding explicit notice of lack of documentation for Tier 2 Platforms - #87677

Merged
bors merged 1 commit into
rust-lang:masterfrom
amalik18:issue-2788-fix
Aug 17, 2021
Merged

Adding explicit notice of lack of documentation for Tier 2 Platforms#87677
bors merged 1 commit into
rust-lang:masterfrom
amalik18:issue-2788-fix

Conversation

@amalik18

@amalik18amalik18 commented Aug 1, 2021

Copy link
Copy Markdown

@rust-highfive

rust-highfive commented Aug 1, 2021

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon.

Please see the contribution instructions for more information.

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 1, 2021
@amalik18amalik18 mentioned this pull request Aug 1, 2021
Open
jyn514
jyn514 reviewed Aug 1, 2021
View reviewed changes
Comment threadsrc/doc/rustc/src/platform-support.md Outdated
@Mark-Simulacrum

Mark-Simulacrum commented Aug 2, 2021

Copy link
Copy Markdown
Member

It looks like a bunch of unrelated changes snuck in here, possibly due to the merge commit - please rebase instead of merging within PRs. Thanks!

@amalik18

amalik18 commented Aug 3, 2021

Copy link
Copy Markdown
Author

It looks like a bunch of unrelated changes snuck in here, possibly due to the merge commit - please rebase instead of merging within PRs. Thanks!

Any good way of squashing all of them?

@amalik18
amalik18force-pushed the issue-2788-fix branch 2 times, most recently from 45bca0c to 360a0a4CompareAugust 3, 2021 01:27
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@jyn514

jyn514 commented Aug 3, 2021

Copy link
Copy Markdown
Member

@amalik18https://rustc-dev-guide.rust-lang.org/git.html#rebasing-and-conflicts

@amalik18

amalik18 commented Aug 3, 2021

Copy link
Copy Markdown
Author

@jyn514 yep it should be good to go

@amalik18
amalik18 requested a review from jyn514August 5, 2021 02:34
@jyn514

jyn514 commented Aug 5, 2021

Copy link
Copy Markdown
Member

@amalik18 I'm not planning to review this - @steveklabnik is assigned and they're a good reviewer for this :)

@amalik18

amalik18 commented Aug 5, 2021

Copy link
Copy Markdown
Author

@amalik18 I'm not planning to review this - @steveklabnik is assigned and they're a good reviewer for this :)

My bad, it listed you in the reviewers section.

@emilyalbini

emilyalbini commented Aug 14, 2021

Copy link
Copy Markdown
Member

@bors r+ rollup

@bors

bors commented Aug 14, 2021

Copy link
Copy Markdown
Collaborator

📌 Commit 4ffb1ef has been approved by pietroalbini

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 14, 2021
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Aug 15, 2021
@GuillaumeGomez
Rollup merge ofrust-lang#87677- amalik18:issue-2788-fix, r=pietroal…
769229c
…bini
Adding explicit notice of lack of documentation for Tier 2 Platforms
Fixing: rust-lang/rustup#2788
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Aug 15, 2021
@GuillaumeGomez
Rollup merge ofrust-lang#87677- amalik18:issue-2788-fix, r=pietroal…
0684748
…bini
Adding explicit notice of lack of documentation for Tier 2 Platforms
Fixing: rust-lang/rustup#2788
This was referenced Aug 15, 2021
Closed
Closed
camsteffen added a commit to camsteffen/rust that referenced this pull request Aug 15, 2021
@camsteffen
Rollup merge ofrust-lang#87677- amalik18:issue-2788-fix, r=pietroal…
dc22db6
…bini
Adding explicit notice of lack of documentation for Tier 2 Platforms
Fixing: rust-lang/rustup#2788
@camsteffencamsteffen mentioned this pull request Aug 15, 2021
Closed
m-ou-se added a commit to m-ou-se/rust that referenced this pull request Aug 16, 2021
@m-ou-se
Rollup merge ofrust-lang#87677- amalik18:issue-2788-fix, r=pietroal…
fad080a
…bini
Adding explicit notice of lack of documentation for Tier 2 Platforms
Fixing: rust-lang/rustup#2788
@m-ou-sem-ou-se mentioned this pull request Aug 16, 2021
Closed
@m-ou-sem-ou-se mentioned this pull request Aug 16, 2021
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 16, 2021
@bors
Auto merge ofrust-lang#88094- m-ou-se:rollup-2fxss0q, r=m-ou-se
0e41c62
Rollup of 10 pull requests
Successful merges:
- rust-lang#87178 ([rustdoc] Copy only item path to clipboard rather than full `use` statement.)
- rust-lang#87677 (Adding explicit notice of lack of documentation for Tier 2 Platforms)
- rust-lang#87958 (Closure migration multispan suggestions)
- rust-lang#87967 (Detect fake spans in non_fmt_panic lint.)
- rust-lang#88011 (Enable `--all-targets` for `x.py check` unconditionally)
- rust-lang#88030 (Assign FIXMEs to me and remove obsolete ones)
- rust-lang#88052 (Update redox_syscall)
- rust-lang#88055 (Update RELEASES.md for 1.55.0)
- rust-lang#88080 (Skip assert ICE with default_method_body_is_const)
- rust-lang#88089 (Rustdoc font test)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 84ca374 into rust-lang:masterAug 17, 2021
@rustbotrustbot added this to the 1.56.0 milestone Aug 17, 2021
@amalik18
amalik18 deleted the issue-2788-fix branch August 30, 2021 02:20
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jyn514jyn514Awaiting requested review from jyn514

Assignees

@steveklabniksteveklabnik

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

1.56.0

Development

Successfully merging this pull request may close these issues.

9 participants

@amalik18@rust-highfive@Mark-Simulacrum@rust-log-analyzer@jyn514@emilyalbini@bors@steveklabnik@rustbot