Uh oh!
There was an error while loading. Please reload this page.
[DO NOT MERGE] -Zthir-unsafeck perf - #87710
Conversation
LeSeulArtichaut
commented
Aug 2, 2021
@bors try @rust-timer queue |
rust-timer
commented
Aug 2, 2021
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
bors
commented
Aug 2, 2021
⌛ Trying commit c248bb5a91572298139eec84b5be92823bb280f1 with merge 2bf0862e70e97046151925d4d66ad8098d0e2596... |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
34b1599 to
c248bb5CompareLeSeulArtichaut
commented
Aug 3, 2021
Looks like bors forgot about this PR? @bors try |
bors
commented
Aug 3, 2021
⌛ Trying commit c248bb5a91572298139eec84b5be92823bb280f1 with merge 81f08a4763e7537b92506fa5a597e6bf774d20cc... |
bors
commented
Aug 3, 2021
☀️ Try build successful - checks-actions |
rust-timer
commented
Aug 3, 2021
Queued 81f08a4763e7537b92506fa5a597e6bf774d20cc with parent e91405b, future comparison URL. |
rust-timer
commented
Aug 3, 2021
Finished benchmarking try commit (81f08a4763e7537b92506fa5a597e6bf774d20cc): comparison url. Summary: This change led to significant mixed results 🤷 in compiler performance.
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf. Next Steps: If you can justify the regressions found in this perf run, please indicate this with @bors rollup=never |
bjorn3
commented
Aug 3, 2021
style-servo-check run incr-patched:
|
LeSeulArtichaut
commented
Aug 3, 2021
I need to investigate the regression on MIR borrowck for incremental builds, but 34b15995f5388f7945b89109a7a45a2edc08297b should fix the regressions for full and incr-full builds. @bors try @rust-timer queue |
rust-timer
commented
Aug 3, 2021
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
bors
commented
Aug 3, 2021
⌛ Trying commit 34b15995f5388f7945b89109a7a45a2edc08297b with merge 56a58d347b1c7dd0c2984b8fc3930c408e26fbc2... |
bors
commented
Aug 3, 2021
☀️ Try build successful - checks-actions |
rust-timer
commented
Aug 3, 2021
Queued 56a58d347b1c7dd0c2984b8fc3930c408e26fbc2 with parent 2939249, future comparison URL. |
rust-timer
commented
Aug 3, 2021
Finished benchmarking try commit (56a58d347b1c7dd0c2984b8fc3930c408e26fbc2): comparison url. Summary: This change led to significant mixed results 🤷 in compiler performance.
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf. Next Steps: If you can justify the regressions found in this perf run, please indicate this with @bors rollup=never |
… r=oli-obk Only compute `is_freeze` for layout-constrained ADTs Places are usually shallow and quick to visit. By contrast, computing `is_freeze` can be much costlier, involving inference and trait solving. Making sure to call `is_freeze` only when necessary should be beneficial for performance in most cases. See [this comparison](https://perf.rust-lang.org/compare.html?start=81f08a4763e7537b92506fa5a597e6bf774d20cc&end=56a58d347b1c7dd0c2984b8fc3930c408e26fbc2&stat=instructions%3Au) from rust-lang#87710. r? `@oli-obk`
bors
commented
Aug 24, 2021
💔 Test failed - checks-actions |
5c22e1a to
0f8bac9CompareLeSeulArtichaut
commented
Aug 24, 2021
@bors try |
bors
commented
Aug 24, 2021
⌛ Trying commit 0f8bac9 with merge 07fecb9cf34c4979a772ba38c99d6d9144768413... |
rust-log-analyzer
commented
Aug 24, 2021
The job Click to see the possible cause of the failure (guessed by this bot) |
bors
commented
Aug 24, 2021
☀️ Try build successful - checks-actions |
LeSeulArtichaut
commented
Aug 24, 2021
Starting a crater experiment to try to find bugs in the THIR unsafeck, and to gather data for related issues #80059 and #87520. @craterbot check |
craterbot
commented
Aug 24, 2021
👌 Experiment ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more |
craterbot
commented
Aug 25, 2021
🚧 Experiment ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more |
LeSeulArtichaut
commented
Aug 26, 2021
@craterbot ping |
craterbot
commented
Aug 26, 2021
🏓 Pong! ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more |
craterbot
commented
Aug 26, 2021
🎉 Experiment
|
There are a lot (855) OOM builds after this PR. Could this be directly related to thir PR? |
@hellow554 The number of OOMs before the PR (in spurious-fixed) seems similar. Also this PR was an improvement in the last max-rss perf benchmarks |
Dylan-DPC
commented
Jun 14, 2022
Closing this as inactive |
Opening this to be able to perf-test the THIR unsafety checker and subsequent attempts to improve its performance.
r? @ghost