Skip to content

Core features cleanup - #87768

Merged
bors merged 5 commits into
masterfrom
core-features-cleanup
Aug 5, 2021
Merged

Core features cleanup#87768
bors merged 5 commits into
masterfrom
core-features-cleanup

Conversation

@m-ou-se

@m-ou-sem-ou-se commented Aug 4, 2021•
edited
Loading

Copy link
Copy Markdown
Member

This sorts and categorizes the #![features] in core and removes unused ones.

This is part of #87766

The following feature attributes were unnecessary and are removed:

// Library features:
-#![feature(bool_to_option)]-#![feature(char_indices_offset)]-#![feature(pin_deref_mut)]-#![feature(str_split_as_str)]-#![feature(str_split_inclusive_as_str)]
// Language features:
-#![feature(arbitrary_self_types)]-#![feature(custom_inner_attributes)]-#![feature(nll)]

@m-ou-sem-ou-se added C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Aug 4, 2021
@rust-highfive

rust-highfive commented Aug 4, 2021

Copy link
Copy Markdown
Contributor

r? @dtolnay

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 4, 2021
@m-ou-sem-ou-se mentioned this pull request Aug 4, 2021
Open
8 tasks
dtolnay
dtolnay approved these changes Aug 4, 2021
View reviewed changes

@dtolnaydtolnay left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@dtolnay

dtolnay commented Aug 4, 2021

Copy link
Copy Markdown
Member

@bors r+

@bors

bors commented Aug 4, 2021

Copy link
Copy Markdown
Collaborator

📌 Commit 7306c69 has been approved by dtolnay

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 4, 2021
@bors

bors commented Aug 5, 2021

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #86155) made this pull request unmergeable. Please resolve the merge conflicts.

@borsbors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 5, 2021
@jyn514

jyn514 commented Aug 5, 2021

Copy link
Copy Markdown
Member

@bors rollup=iffy

@m-ou-se
m-ou-seforce-pushed the core-features-cleanup branch from 7306c69 to cdf83c0CompareAugust 5, 2021 10:57
@m-ou-se

m-ou-se commented Aug 5, 2021

Copy link
Copy Markdown
MemberAuthor

Rebased after another PR already removed unwind_attributes attriute.

@bors r=dtolnay

@bors

bors commented Aug 5, 2021

Copy link
Copy Markdown
Collaborator

📌 Commit cdf83c0 has been approved by dtolnay

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 5, 2021
@bors

bors commented Aug 5, 2021

Copy link
Copy Markdown
Collaborator

⌛ Testing commit cdf83c0 with merge 5caae6edbc5c6a605e585a5b30d5eab6c325c427...

@bors

bors commented Aug 5, 2021

Copy link
Copy Markdown
Collaborator

💔 Test failed - checks-actions

@borsbors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 5, 2021
@rust-log-analyzer

rust-log-analyzer commented Aug 5, 2021

Copy link
Copy Markdown
Collaborator

A job failed! Check out the build log: (web)(plain)

Click to see the possible cause of the failure (guessed by this bot)

@jyn514

jyn514 commented Aug 5, 2021

Copy link
Copy Markdown
Member

dist-mingw failed without logs.

@bors retry

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 5, 2021
@bors

bors commented Aug 5, 2021

Copy link
Copy Markdown
Collaborator

⌛ Testing commit cdf83c0 with merge 2f07ae4...

@bors

bors commented Aug 5, 2021

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions
Approved by: dtolnay
Pushing 2f07ae4 to master...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Aug 5, 2021
@bors
bors merged commit 2f07ae4 into masterAug 5, 2021
@bors
bors deleted the core-features-cleanup branch August 5, 2021 20:37
@rustbotrustbot added this to the 1.56.0 milestone Aug 5, 2021
This was referenced Aug 5, 2021
Closed
Merged
Merged
Merged
Merged
Merged
@dtolnaydtolnay mentioned this pull request Aug 15, 2021
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dtolnaydtolnaydtolnay approved these changes

Assignees

@dtolnaydtolnay

Labels

C-cleanupCategory: PRs that clean code up or issues documenting cleanup.merged-by-borsThis PR was explicitly merged by bors.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.56.0

Development

Successfully merging this pull request may close these issues.

7 participants

@m-ou-se@rust-highfive@dtolnay@bors@jyn514@rust-log-analyzer@rustbot