Skip to content

Alloc features cleanup - #87769

Merged
bors merged 4 commits into
rust-lang:masterfrom
m-ou-se:alloc-features-cleanup
Oct 20, 2021
Merged

Alloc features cleanup#87769
bors merged 4 commits into
rust-lang:masterfrom
m-ou-se:alloc-features-cleanup

Conversation

@m-ou-se

Copy link
Copy Markdown
Member

This sorts and categorizes the #![features] in alloc and removes unused ones.

This is part of #87766

The following feature attributes were unnecessary and are removed:

// Library features:
-#![feature(cow_is_borrowed)]-#![feature(maybe_uninit_uninit_array)]-#![feature(slice_partition_dedup)]
// Language features:
-#![feature(arbitrary_self_types)]-#![feature(auto_traits)]-#![feature(box_patterns)]-#![feature(decl_macro)]-#![feature(nll)]

@m-ou-sem-ou-se added C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Aug 4, 2021
@rust-highfive

Copy link
Copy Markdown
Contributor

r? @yaahc

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 4, 2021
@bjorn3

Copy link
Copy Markdown
Member
-#![feature(nll)]

These exist to test full nll mode. #66498 (comment)

@m-ou-se

Copy link
Copy Markdown
MemberAuthor

If we really need to keep that in alloc and/or core, we should put a clear comment why it's there. Is there any documentation of what enabling this feature will change?

@bjorn3

Copy link
Copy Markdown
Member

NLL is currently in migration mode by default, which still uses the old AST based regionck. #![feature(nll)] completes the transition to full NLL mode. #57895 is the tracking issue for completing the transition. One of the last remaining blockers for completing the transition is #86700 I think. By the way libstd used to require it at least at some point: #66494 (comment)

@yaahc

yaahc commented Aug 5, 2021

Copy link
Copy Markdown
Member

LGTM once the NLL bit is sorted.

@bors

bors commented Aug 18, 2021

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #86808) made this pull request unmergeable. Please resolve the merge conflicts.

@JohnCSimonJohnCSimon added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 6, 2021
@JohnCSimonJohnCSimon added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 27, 2021
@dtolnay

Copy link
Copy Markdown
Member

@bors delegate+

Looks good after a rebase and putting back #![feature(nll)].

@bors

bors commented Oct 3, 2021

Copy link
Copy Markdown
Collaborator

✌️ @m-ou-se can now approve this pull request

@dtolnaydtolnay added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 3, 2021
@JohnCSimonJohnCSimon added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 19, 2021
@m-ou-se
m-ou-seforce-pushed the alloc-features-cleanup branch from d7672fb to 6fdcedcCompareOctober 19, 2021 12:57
@m-ou-se

Copy link
Copy Markdown
MemberAuthor

@bors r=yaahc,dtolnay

@bors

bors commented Oct 19, 2021

Copy link
Copy Markdown
Collaborator

📌 Commit 6fdcedc has been approved by yaahc,dtolnay

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 19, 2021
@JohnTitorJohnTitor mentioned this pull request Oct 19, 2021
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 19, 2021
Rollup of 10 pull requests
Successful merges:
- rust-lang#86479 (Automatic exponential formatting in Debug)
- rust-lang#87404 (Add support for artifact size profiling)
- rust-lang#87769 (Alloc features cleanup)
- rust-lang#88789 (remove unnecessary bound on Zip specialization impl)
- rust-lang#88860 (Deduplicate panic_fmt)
- rust-lang#90009 (Make more `From` impls `const` (libcore))
- rust-lang#90018 (Fix rustdoc UI for very long type names)
- rust-lang#90025 (Revert rust-lang#86011 to fix an incorrect bound check)
- rust-lang#90036 (Remove border-bottom from most docblocks.)
- rust-lang#90060 (Update RELEASES.md)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 71fcb72 into rust-lang:masterOct 20, 2021
@rustbotrustbot added this to the 1.58.0 milestone Oct 20, 2021
@m-ou-se
m-ou-se deleted the alloc-features-cleanup branch October 20, 2021 06:28
@dtolnaydtolnay self-assigned this Mar 25, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-cleanupCategory: PRs that clean code up or issues documenting cleanup.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants

@m-ou-se@rust-highfive@bjorn3@yaahc@bors@dtolnay@JohnCSimon@rustbot