Skip to content

Tracking issue for UNSUPPORTED_CALLING_CONVENTIONS - #88397

Merged
bors merged 1 commit into
rust-lang:masterfrom
nagisa:nagisa/unsupported-calling-conventions
Aug 27, 2021
Merged

Tracking issue for UNSUPPORTED_CALLING_CONVENTIONS#88397
bors merged 1 commit into
rust-lang:masterfrom
nagisa:nagisa/unsupported-calling-conventions

Conversation

@nagisa

@nagisanagisa commented Aug 27, 2021

Copy link
Copy Markdown
Member

This was previously forgotten. Nominating for 1.55 as this lint will make it into stable in that release.

r? @Mark-Simulacrum

@nagisanagisa added beta-nominated Nominated for backporting to the compiler in the beta channel. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 27, 2021
@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 27, 2021
@nagisanagisa mentioned this pull request Aug 27, 2021
Closed
@Mark-Simulacrum

Mark-Simulacrum commented Aug 27, 2021

Copy link
Copy Markdown
Member

@bors r+ p=1

@bors

bors commented Aug 27, 2021

Copy link
Copy Markdown
Collaborator

📌 Commit 5b21fe0d7442cb4448ba6e19210c6fb73394527a has been approved by Mark-Simulacrum

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 27, 2021
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@nagisa

nagisa commented Aug 27, 2021

Copy link
Copy Markdown
MemberAuthor

Ah, I should've blessed the tests. will do it whenever I fix my build environment.

@Mark-Simulacrum

Mark-Simulacrum commented Aug 27, 2021

Copy link
Copy Markdown
Member

@bors r- for now

@borsbors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 27, 2021
@nagisa
nagisaforce-pushed the nagisa/unsupported-calling-conventions branch from 5b21fe0 to fb5fbaaCompareAugust 27, 2021 17:47
@nagisa

nagisa commented Aug 27, 2021

Copy link
Copy Markdown
MemberAuthor

@bors r=Mark-Simulacrum

@bors

bors commented Aug 27, 2021

Copy link
Copy Markdown
Collaborator

📌 Commit fb5fbaa has been approved by Mark-Simulacrum

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 27, 2021
@bors

bors commented Aug 27, 2021

Copy link
Copy Markdown
Collaborator

⌛ Testing commit fb5fbaa with merge dfd8472...

@bors

bors commented Aug 27, 2021

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing dfd8472 to master...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Aug 27, 2021
@bors
bors merged commit dfd8472 into rust-lang:masterAug 27, 2021
@rustbotrustbot added this to the 1.56.0 milestone Aug 27, 2021
@nagisanagisa mentioned this pull request Aug 30, 2021
Merged
@apiraino

apiraino commented Sep 2, 2021

Copy link
Copy Markdown
Contributor

Beta backport accepted as per compiler team on Zulip

@rustbot label +beta-accepted

@rustbotrustbot added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Sep 2, 2021
@Mark-SimulacrumMark-Simulacrum mentioned this pull request Sep 4, 2021
Merged
@Mark-SimulacrumMark-Simulacrum removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Sep 4, 2021
@Mark-SimulacrumMark-Simulacrum modified the milestones: 1.56.0, 1.55.0Sep 4, 2021
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 4, 2021
@bors
Auto merge ofrust-lang#88641- Mark-Simulacrum:beta-next, r=Mark-Sim…
e721434
…ulacrum
[beta] backports
This PR backports:
* Concrete regions can show up in mir borrowck if the originated from there rust-lang#88533 (fixesrust-lang#83190)
* Fix loading large rlibs rust-lang#88506 (fixesrust-lang#88351)
* Display associated types of implementors rust-lang#88490 (fixesrust-lang#86631)
* Tracking issue for UNSUPPORTED_CALLING_CONVENTIONS rust-lang#88397
r? `@Mark-Simulacrum`
@RalfJungRalfJung mentioned this pull request Sep 3, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 3, 2024
@bors
Auto merge ofrust-lang#129935- RalfJung:unsupported_calling_convent…
498fce2
…ions, r=
make unsupported_calling_conventions a hard error
This has been a future-compat lint (not shown in dependencies) since Rust 1.55, released 3 years ago. Hopefully that was enough time so this can be made a hard error now. Given that long timeframe, I think it's justified to skip the "show in dependencies" stage. There were [not many crates hitting this](rust-lang#86231 (comment)) even when the PR was landed.
This should get cratered, and I assume then it needs a t-compiler FCP.
Fixesrust-lang#88397
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Mark-SimulacrumMark-Simulacrum

Labels

beta-acceptedAccepted for backporting to the compiler in the beta channel.merged-by-borsThis PR was explicitly merged by bors.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.55.0

Development

Successfully merging this pull request may close these issues.

7 participants

@nagisa@Mark-Simulacrum@bors@rust-log-analyzer@apiraino@rust-highfive@rustbot