Skip to content

Remove ignore-tidy-undocumented-unsafe from core::slice::sort - #88412

Merged
bors merged 1 commit into
rust-lang:masterfrom
mdsn:slice-sort-safety
Sep 30, 2021
Merged

Remove ignore-tidy-undocumented-unsafe from core::slice::sort#88412
bors merged 1 commit into
rust-lang:masterfrom
mdsn:slice-sort-safety

Conversation

@mdsn

@mdsnmdsn commented Aug 28, 2021

Copy link
Copy Markdown
Contributor

Write down the missing safety arguments to be able to remove ignore-tidy-undocumented-unsafe from core::slice::sort.

Helps with #66219

@rustbot label C-cleanup T-libs

@rustbotrustbot added C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Aug 28, 2021
@rust-highfive

Copy link
Copy Markdown
Contributor

r? @dtolnay

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 28, 2021
@JohnCSimonJohnCSimon added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 13, 2021

@dtolnaydtolnay left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dtolnay

Copy link
Copy Markdown
Member

@bors r+ rollup

@bors

bors commented Sep 29, 2021

Copy link
Copy Markdown
Collaborator

📌 Commit 18fb97e has been approved by dtolnay

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 29, 2021
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Sep 29, 2021
Remove ignore-tidy-undocumented-unsafe from core::slice::sort
Write down the missing safety arguments to be able to remove `ignore-tidy-undocumented-unsafe` from `core::slice::sort`.
Helps with rust-lang#66219
`@rustbot` label C-cleanup T-libs
@ehussehuss mentioned this pull request Sep 30, 2021
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 30, 2021
Rollup of 13 pull requests
Successful merges:
- rust-lang#87428 (Fix union keyword highlighting in rustdoc HTML sources)
- rust-lang#88412 (Remove ignore-tidy-undocumented-unsafe from core::slice::sort)
- rust-lang#89098 (Fix generics where bounds order)
- rust-lang#89232 (Improve help for recursion limit errors)
- rust-lang#89294 (:arrow_up: rust-analyzer)
- rust-lang#89297 (Remove Never variant from clean::Type enum)
- rust-lang#89311 (Add unit assignment to MIR for `asm!()`)
- rust-lang#89313 (PassWrapper: handle function rename from upstream D36850)
- rust-lang#89315 (Clarify that `CString::from_vec_unchecked` appends 0 byte.)
- rust-lang#89335 (Optimize is_sorted for Range and RangeInclusive)
- rust-lang#89366 (rustdoc: Remove lazy_static dependency)
- rust-lang#89377 (Update cargo)
- rust-lang#89378 (Update books)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit e24f522 into rust-lang:masterSep 30, 2021
@rustbotrustbot added this to the 1.57.0 milestone Sep 30, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-cleanupCategory: PRs that clean code up or issues documenting cleanup.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@mdsn@rust-highfive@dtolnay@bors@JohnCSimon@rustbot