Uh oh!
There was an error while loading. Please reload this page.
Remove some feature gates - #88481
Merged
Merged
Conversation
rust-highfive
commented
Aug 30, 2021
Contributor
r? @cjgillot (rust-highfive has picked a reviewer for you, use r? to override) |
Uh oh!
There was an error while loading. Please reload this page.
bjorn3force-pushed
the
remove_feature_gates
branch
from
August 30, 2021 10:12
8c87b90 to
f622b5dCompareUh oh!
There was an error while loading. Please reload this page.
For some reason unboxed_closures supresses the feature gate for min_specialization when implementing TrustedStep. min_specialization is the true feature that is used.
bjorn3force-pushed
the
remove_feature_gates
branch
from
October 2, 2021 17:09
f622b5d to
873860dCompare
This comment has been minimized.
This comment has been minimized.
bjorn3force-pushed
the
remove_feature_gates
branch
from
October 2, 2021 17:47
873860d to
05b4614Compare
This comment has been minimized.
This comment has been minimized.
cjgillot
commented
Oct 2, 2021
Contributor
r=me once CI passes. |
This is cleaner and removes an unstable feature usage
bjorn3force-pushed
the
remove_feature_gates
branch
from
October 3, 2021 15:51
05b4614 to
9f4cb86Comparebjorn3
commented
Oct 3, 2021
MemberAuthor
@bors r=cjgillot |
bors
commented
Oct 3, 2021
Collaborator
📌 Commit 9f4cb86 has been approved by |
Manishearth added a commit
to Manishearth/rust
that referenced
this pull request
Oct 4, 2021
…llot Remove some feature gates The first commit removes various feature gates that are unused. The second commit replaces some `Fn` implementations with `Iterator` implementations, which is much cleaner IMO. The third commit replaces an unboxed_closures feature gate with min_specialization. For some reason the unboxed_closures feature gate suppresses the min_specialization feature gate from triggering on an `TrustedStep` impl. The last comment just turns a regular comment into a doc comment as drive by cleanup. I can move it to a separate PR if preferred.
This was referenced Oct 4, 2021
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 4, 2021
…arth Rollup of 14 pull requests Successful merges: - rust-lang#86434 (Add `Ipv6Addr::is_benchmarking`) - rust-lang#86828 (const fn for option copied, take & replace) - rust-lang#87679 (BTree: refine some comments) - rust-lang#87910 (Mark unsafe methods NonZero*::unchecked_(add|mul) as const.) - rust-lang#88286 (Remove unnecessary unsafe block in `process_unix`) - rust-lang#88305 (Manual Debug for Unix ExitCode ExitStatus ExitStatusError) - rust-lang#88353 (Partially stabilize `array_methods`) - rust-lang#88370 (Add missing `# Panics` section to `Vec` method) - rust-lang#88481 (Remove some feature gates) - rust-lang#89138 (Fix link in Ipv6Addr::to_ipv4 docs) - rust-lang#89401 (Add truncate note to Vec::resize) - rust-lang#89467 (Fix typos in rustdoc/lints) - rust-lang#89472 (Only register `WSACleanup` if `WSAStartup` is actually ever called) - rust-lang#89505 (Add regression test for spurious const error with NLL) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first commit removes various feature gates that are unused. The second commit replaces some
Fnimplementations withIteratorimplementations, which is much cleaner IMO. The third commit replaces an unboxed_closures feature gate with min_specialization. For some reason the unboxed_closures feature gate suppresses the min_specialization feature gate from triggering on anTrustedStepimpl. The last comment just turns a regular comment into a doc comment as drive by cleanup. I can move it to a separate PR if preferred.