Uh oh!
There was an error while loading. Please reload this page.
Add regression test for #74400 - #88541
Conversation
rust-highfive
commented
Aug 31, 2021
(rust-highfive has picked a reviewer for you, use r? to override) |
This comment has been minimized.
This comment has been minimized.
7f97a51 to
adeb14bCompare
This comment has been minimized.
This comment has been minimized.
vandenheuvel
commented
Sep 1, 2021
I'm trying to add a regression test for #74400 because it seems resolved: the nightly on the playground gives the right error, see this comment. Yet, when I add the test as in the PR linked above, I get the old, wrong error. I tried the same thing with a local project and latest nightly, and got the same result. Could you help me understand, why running the test using |
adeb14b to
a6dbaa8CompareMark-Simulacrum
commented
Sep 4, 2021
I pushed up a locally blessed version which I think should work in CI as well. I'm not sure, but it's possible you were locally creating the stderr file with an older master? It looks like it branched off in february, which may have been before the recent-ish improvements in the last month or so? |
a6dbaa8 to
9d0c264Compare
This comment has been minimized.
This comment has been minimized.
9d0c264 to
86ff232Compare86ff232 to
fe7bcd6Comparevandenheuvel
commented
Sep 6, 2021
@Mark-Simulacrum I think this is ready. |
Mark-Simulacrum
commented
Sep 6, 2021
@bors r+ rollup |
bors
commented
Sep 6, 2021
📌 Commit fe7bcd6 has been approved by |
Rollup of 9 pull requests Successful merges: - rust-lang#86263 (Rustdoc: Report Layout of enum variants) - rust-lang#88541 (Add regression test for rust-lang#74400) - rust-lang#88553 (Improve diagnostics for unary plus operators (rust-lang#88276)) - rust-lang#88594 (More symbolic doc aliases) - rust-lang#88648 (Correct “copies” to “moves” in `<Option<T> as From<T>>::from` doc, and other copyediting) - rust-lang#88691 (Add a regression test for rust-lang#88649) - rust-lang#88694 (Drop 1.56 stabilizations from 1.55 release notes) - rust-lang#88712 (Fix docs for `uX::checked_next_multiple_of`) - rust-lang#88726 (Fix typo in `const_generics` replaced with `adt_const_params` note) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Closes#74400 by adding a regression test.