Uh oh!
There was an error while loading. Please reload this page.
Rollup of 12 pull requests - #88596
Merged
Merged
Conversation
Co-authored-by: kennytm <kennytm@gmail.com>
Previously, `QueryJobInfo` was composed of two parts: a `QueryInfo` and a `QueryJob`. However, both `QueryInfo` and `QueryJob` have a `span` field, which seem to be the same. So, the `span` was recorded twice. Now, `QueryJobInfo` is composed of a `QueryStackFrame` (the other field of `QueryInfo`) and a `QueryJob`. So, now, the `span` is only recorded once.
Instead, return `Type::Infer` since compilation should fail anyway. That's how rustdoc handles `hir::TyKind::Err`s, so this just extends that behavior to `ty::Err`s when analyzing associated types. For some reason, the error is printed twice with rustdoc (though only once with rustc). I'm not sure why that is, but it's better than panicking. This commit also makes rustdoc fail early in the non-projection, non-error case, instead of returning a `Res::Err` that would likely cause rustdoc to panic later on. This change is originally from rust-lang#88379.
…ou-se Stabilize std::os::unix::fs::chroot I've verified that this works as documented, and I've tested it in (a nightly build of) production software as a replacement for an unsafe call to `libc::chroot`. It's been available in nightly for a few releases. I think it's ready to stabilize. --- Tracking issue: rust-lang#84715
…=kennytm Use `unwrap_unchecked` where possible
…, r=estebank Upgrade array_into_iter lint to include Deref-to-array types. Fixesrust-lang#88099 Fixes the issue mentioned here: rust-lang#84147 (comment)
Remove single use variables
…ck-fragment, r=estebank Improve closure dummy capture suggestion in macros. Fixes some cases of rust-lang#88440 Fixes https://crater-reports.s3.amazonaws.com/pr-87190-3/try%23a7a572ce3edd6d476191fbfe92c9c1986e009b34/reg/rcodec-1.0.1/log.txt
`fmt::Formatter::pad`: don't call chars().count() more than one time First commit merges two branches of match to call chars().count() only once: that should be faster if this method hits place of 3rd (previous) branch, plus quarter shorter. Second commit fixes some clippy lints while i'm here (should it be separate PR?).
Add regression test for issue 83190 Reduced from `bioyino-metric` by ````@hellow554```` and myself. Closesrust-lang#83190. r? ````@spastorino````
Remove redundant `Span` in `QueryJobInfo` Previously, `QueryJobInfo` was composed of two parts: a `QueryInfo` and a `QueryJob`. However, both `QueryInfo` and `QueryJob` have a `span` field, which seem to be the same. So, the `span` was recorded twice. Now, `QueryJobInfo` is composed of a `QueryStackFrame` (the other field of `QueryInfo`) and a `QueryJob`. So, now, the `span` is only recorded once.
…laumeGomez rustdoc: Don't panic on ambiguous inherent associated types Instead, return `Type::Infer` since compilation should fail anyway. That's how rustdoc handles `hir::TyKind::Err`s, so this just extends that behavior to `ty::Err`s when analyzing associated types. For some reason, the error is printed twice with rustdoc (though only once with rustc). I'm not sure why that is, but it's better than panicking. This commit also makes rustdoc fail early in the non-projection, non-error case, instead of returning a `Res::Err` that would likely cause rustdoc to panic later on. This change is originally from rust-lang#88379. r? `@GuillaumeGomez`
Implement rust-lang#88581 See rust-lang#88581 for details. This API was discussed on Zulip. `@rustbot` label: +T-libs-api +S-waiting-on-review r? `@joshtriplett`
…oc, r=petrochenkov Correct doc comments inside `use_expr_visitor.rs` Just a simple update. I haven't changed any content inside the comments, as they still seem correct. Have a wonderful rest of the day 🙃
Fix ICE in const check Fixesrust-lang#88433
m-ou-se
commented
Sep 2, 2021
MemberAuthor
@bors r+ rollup=never p=5 |
bors
commented
Sep 2, 2021
Collaborator
📌 Commit c082e15 has been approved by |
bors
commented
Sep 2, 2021
Collaborator
bors
commented
Sep 2, 2021
Collaborator
☀️ Test successful - checks-actions |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
unwrap_uncheckedwhere possible #88505 (Useunwrap_uncheckedwhere possible)fmt::Formatter::pad: don't call chars().count() more than one time #88560 (fmt::Formatter::pad: don't call chars().count() more than one time)SpaninQueryJobInfo#88567 (Remove redundantSpaninQueryJobInfo)int_roundings#88581)use_expr_visitor.rs#88589 (Correct doc comments insideuse_expr_visitor.rs)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup