Skip to content

Make UnsafeCell::get_mut const - #88722

Merged
bors merged 2 commits into
rust-lang:masterfrom
WaffleLapkin:unsafe_cell_const_get_mut
Sep 14, 2021
Merged

Make UnsafeCell::get_mut const#88722
bors merged 2 commits into
rust-lang:masterfrom
WaffleLapkin:unsafe_cell_const_get_mut

Conversation

@WaffleLapkin

Copy link
Copy Markdown
Member

No description provided.

@rust-highfive

Copy link
Copy Markdown
Contributor

r? @dtolnay

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 7, 2021
@the8472the8472 added the T-libs-api [DEPRECATED; DO NOT USE] label Sep 8, 2021

@dtolnaydtolnay left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me. Can you make a tracking issue or tack this on to an existing appropriate one?

@WaffleLapkin

Copy link
Copy Markdown
MemberAuthor

@dtolnay done

@dtolnaydtolnay left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dtolnay

Copy link
Copy Markdown
Member

@bors r+ rollup

@bors

bors commented Sep 12, 2021

Copy link
Copy Markdown
Collaborator

📌 Commit 2c30162 has been approved by dtolnay

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 12, 2021
workingjubilee added a commit to workingjubilee/rustc that referenced this pull request Sep 12, 2021
…mut, r=dtolnay
Make `UnsafeCell::get_mut` const
Manishearth added a commit to Manishearth/rust that referenced this pull request Sep 12, 2021
…mut, r=dtolnay
Make `UnsafeCell::get_mut` const
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Sep 13, 2021
…mut, r=dtolnay
Make `UnsafeCell::get_mut` const
This was referenced Sep 13, 2021
workingjubilee added a commit to workingjubilee/rustc that referenced this pull request Sep 14, 2021
…mut, r=dtolnay
Make `UnsafeCell::get_mut` const
workingjubilee added a commit to workingjubilee/rustc that referenced this pull request Sep 14, 2021
…mut, r=dtolnay
Make `UnsafeCell::get_mut` const
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 14, 2021
…laumeGomez
Rollup of 7 pull requests
Successful merges:
- rust-lang#88033 (Add links for primitives in "jump to definition" feature)
- rust-lang#88722 (Make `UnsafeCell::get_mut` const)
- rust-lang#88851 (Fix duplicate bounds for const_trait_impl)
- rust-lang#88859 (interpreter PointerArithmetic: use new Size helper methods)
- rust-lang#88885 (Fix jump def background)
- rust-lang#88894 (Improve error message for missing trait in trait impl)
- rust-lang#88896 (Reduce possibility of flaky tests)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 5eb7783 into rust-lang:masterSep 14, 2021
@WaffleLapkin
WaffleLapkin deleted the unsafe_cell_const_get_mut branch September 18, 2021 15:54
@cuvipercuviper added this to the 1.57.0 milestone Nov 16, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-libs-api[DEPRECATED; DO NOT USE]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@WaffleLapkin@rust-highfive@dtolnay@bors@cuviper@the8472