Use FxHashSet instead of Vec for well formed tys by jackh726 · Pull Request #88771 · rust-lang/rust

jackh726 · 2021-09-09T03:40:38Z

Trying to recover perf from #88312

r? @ghost

jackh726 · 2021-09-09T03:41:10Z

@bors try @rust-timer queue

rust-timer · 2021-09-09T03:41:11Z

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

bors · 2021-09-09T03:41:18Z

⌛ Trying commit ba67d85ae338bbb4ab1b840e9bf57883cad1efdd with merge 05ee7be89fecd02defa835ceae7c6c57e8582a12...

bors · 2021-09-09T05:04:23Z

☀️ Try build successful - checks-actions
Build commit: 05ee7be89fecd02defa835ceae7c6c57e8582a12 (05ee7be89fecd02defa835ceae7c6c57e8582a12)

rust-timer · 2021-09-09T05:04:25Z

Queued 05ee7be89fecd02defa835ceae7c6c57e8582a12 with parent 626649f, future comparison URL.

rust-timer · 2021-09-09T06:46:22Z

Finished benchmarking commit (05ee7be89fecd02defa835ceae7c6c57e8582a12): comparison url.

Summary: This change led to large relevant improvements 🎉 in compiler performance.

Large improvement in instruction counts (up to -2.6% on full builds of externs)

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

jackh726 · 2021-09-09T15:27:07Z

@bors try @rust-timer queue

rust-timer · 2021-09-09T15:27:08Z

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

bors · 2021-09-09T15:27:14Z

⌛ Trying commit 8e7613f with merge 4508123e015a7afc057ce1b1b417413dc7c45059...

bors · 2021-09-09T16:48:07Z

☀️ Try build successful - checks-actions
Build commit: 4508123e015a7afc057ce1b1b417413dc7c45059 (4508123e015a7afc057ce1b1b417413dc7c45059)

rust-timer · 2021-09-09T16:48:08Z

Queued 4508123e015a7afc057ce1b1b417413dc7c45059 with parent 497ee32, future comparison URL.

rust-timer · 2021-09-09T19:15:18Z

Finished benchmarking commit (4508123e015a7afc057ce1b1b417413dc7c45059): comparison url.

Summary: This change led to large relevant improvements 🎉 in compiler performance.

Large improvement in instruction counts (up to -2.6% on full builds of externs)

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

jackh726 · 2021-09-09T19:31:45Z

Doesn't win back all the perf lost from #88312, but is better. I'm not sure that there's a way to win more perf without changing the approach completely. So, I think this is probably worth merging and accepting the difference.

cc @rylev regarding perf
cc @nikomatsakis who might want to steal this review

r? rust-lang/compiler

nikomatsakis · 2021-09-10T15:35:28Z

@bors r+

bors · 2021-09-10T15:35:29Z

📌 Commit 8e7613f has been approved by nikomatsakis

bors · 2021-09-10T15:35:30Z

🌲 The tree is currently closed for pull requests below priority 100. This pull request will be tested once the tree is reopened.

bors · 2021-09-12T10:32:58Z

⌛ Testing commit 8e7613f with merge 9ef27bf...

bors · 2021-09-12T13:29:50Z

☀️ Test successful - checks-actions
Approved by: nikomatsakis
Pushing 9ef27bf to master...

rust-timer · 2021-09-12T16:24:25Z

Finished benchmarking commit (9ef27bf): comparison url.

Summary: This change led to large relevant improvements 🎉 in compiler performance.

Large improvement in instruction counts (up to -2.6% on full builds of externs)

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

eddyb · 2021-09-18T00:57:59Z

- fn_sig_tys: &[Ty<'tcx>],
+ fn_sig_tys: FxHashSet<Ty<'tcx>>,
 body_id: hir::HirId,
 span: Span,
 ) {
 debug!("add_implied_bounds()");

- for &ty in fn_sig_tys {
+ for ty in fn_sig_tys {


This is iterating on a FxHashSet<Ty<'tcx>>, which will depend on ASLR (random memory allocation order) and the results could be observable (e.g. potentially in diagnostics order).
I wonder if we should ban iterating FxHash{Set,Map} and force the use of FxIndex{Set,Map} instead (since presumably the insertion order is deterministic).

See also #63713 (comment) - we should probably use internal lints to force this harder.

we should ban iterating FxHash{Set,Map}
YES! I think recommending FxIndex{Set,Map} is probably the right choice, using an internal lint when using a FxIndexSet in a potentially nondet way. Now if the order doesn't matter, e.g. checking for existence without any sideeffects, this lint could be explicitly allowed.
Not sure what's the best way to write such a lint though 😅

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Sep 9, 2021

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Sep 9, 2021

jackh726 added 2 commits September 9, 2021 11:25

Use FxHashSet instead of Vec for well formed tys
c49b076

Only add_implied_bounds for norm_ty if different
8e7613f

jackh726 force-pushed the wf_tys_set branch from dec51b5 to 8e7613fCompare September 9, 2021 15:26

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Sep 9, 2021

rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Sep 9, 2021

jackh726 changed the title ~~[perf] Use FxHashSet instead of Vec for well formed tys~~Use FxHashSet instead of Vec for well formed tysSep 9, 2021

rust-highfive assigned oli-obk Sep 9, 2021

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 10, 2021

bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 12, 2021

bors merged commit 9ef27bf into rust-lang:masterSep 12, 2021

rustbot added this to the 1.57.0 milestone Sep 12, 2021

jackh726 deleted the wf_tys_set branch September 12, 2021 14:55

jackh726 mentioned this pull request Sep 12, 2021
Treat types in unnormalized function signatures as well-formed #88312
Merged

eddyb reviewed Sep 18, 2021
View reviewed changes

jackh726 restored the wf_tys_set branch March 12, 2022 18:30

jackh726 deleted the wf_tys_set branch March 12, 2022 18:35

jackh726 restored the wf_tys_set branch March 12, 2022 18:42

jackh726 deleted the wf_tys_set branch March 12, 2022 18:53

jieyouxu mentioned this pull request Aug 14, 2024
Tracking Issue for Reproducible Build bugs and challenges #129080
Open
81 tasks

Uh oh!

Uh oh!

Conversation

jackh726 commented Sep 9, 2021

Uh oh!

jackh726 commented Sep 9, 2021

Uh oh!

rust-timer commented Sep 9, 2021

Uh oh!

bors commented Sep 9, 2021

Uh oh!

bors commented Sep 9, 2021

Uh oh!

rust-timer commented Sep 9, 2021

Uh oh!

rust-timer commented Sep 9, 2021

Uh oh!

jackh726 commented Sep 9, 2021

Uh oh!

rust-timer commented Sep 9, 2021

Uh oh!

bors commented Sep 9, 2021

Uh oh!

bors commented Sep 9, 2021

Uh oh!

rust-timer commented Sep 9, 2021

Uh oh!

rust-timer commented Sep 9, 2021

Uh oh!

jackh726 commented Sep 9, 2021

Uh oh!

nikomatsakis commented Sep 10, 2021

Uh oh!

bors commented Sep 10, 2021

Uh oh!

bors commented Sep 10, 2021

Uh oh!

bors commented Sep 12, 2021

Uh oh!

bors commented Sep 12, 2021

Uh oh!

rust-timer commented Sep 12, 2021

Uh oh!

eddybSep 18, 2021

Choose a reason for hiding this comment

Uh oh!

eddybSep 18, 2021

Choose a reason for hiding this comment

Uh oh!

lcnrSep 18, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

lcnrSep 18, 2021•
edited
Loading