Skip to content

Workaround blink/chromium grid layout limitation of 1000 rows - #88776

Merged
bors merged 1 commit into
rust-lang:masterfrom
dns2utf8:rustdoc_workaround_1000_elements_grid_bug
Sep 11, 2021
Merged

Workaround blink/chromium grid layout limitation of 1000 rows#88776
bors merged 1 commit into
rust-lang:masterfrom
dns2utf8:rustdoc_workaround_1000_elements_grid_bug

Conversation

@dns2utf8

@dns2utf8dns2utf8 commented Sep 9, 2021

Copy link
Copy Markdown
Contributor

I made this in case we don't come up with a better solution in time.

See #88545 for more details.

A rendered version of the standard library is hosted here:
https://data.estada.ch/rustdoc-nightly_497ee321af_2021-09-09/core/arch/arm/index.html

r? @GuillaumeGomez@jsha

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 9, 2021
@GuillaumeGomez

GuillaumeGomez commented Sep 9, 2021

Copy link
Copy Markdown
Member

Waiting for then CI then I r+ it.

@GuillaumeGomez

GuillaumeGomez commented Sep 9, 2021

Copy link
Copy Markdown
Member

@bors: r+ rollup

@bors

bors commented Sep 9, 2021

Copy link
Copy Markdown
Collaborator

📌 Commit 0bf16af has been approved by GuillaumeGomez

@bors

bors commented Sep 9, 2021

Copy link
Copy Markdown
Collaborator

🌲 The tree is currently closed for pull requests below priority 100. This pull request will be tested once the tree is reopened.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 9, 2021
@GuillaumeGomez

GuillaumeGomez commented Sep 9, 2021

Copy link
Copy Markdown
Member

Thanks!

@dns2utf8

dns2utf8 commented Sep 9, 2021

Copy link
Copy Markdown
ContributorAuthor

You are welcome!
Btw. I just realised, if there is a 1.55.1 release: This PR should probably be included in that

@dns2utf8dns2utf8 mentioned this pull request Sep 10, 2021
Merged
@dns2utf8

dns2utf8 commented Sep 10, 2021

Copy link
Copy Markdown
ContributorAuthor

I tested the workaround with IE Edge 92 and Chrome 93 and it works okay.
Safari on Mac and Firefox worked before already and behave the same as the blink based browsers now ☺️

@GuillaumeGomez

GuillaumeGomez commented Sep 10, 2021

Copy link
Copy Markdown
Member

Good point, let's nominate it for beta backport.

Do you accept this to be backported to beta @rust-lang/rustdoc?

@GuillaumeGomezGuillaumeGomez added A-rustdoc-ui Area: Rustdoc UI (generated HTML) beta-nominated Nominated for backporting to the compiler in the beta channel. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Sep 10, 2021
@Nemo157

Nemo157 commented Sep 10, 2021

Copy link
Copy Markdown
Contributor

Was the issue a beta regression?

@GuillaumeGomez

GuillaumeGomez commented Sep 10, 2021

Copy link
Copy Markdown
Member

I think it reached the 1.56 beta version, so yes, it's a regression.

@Nemo157

Nemo157 commented Sep 10, 2021

Copy link
Copy Markdown
Contributor

I was more wondering whether it was not already in stable, looking back at the history I assume #85651 introduced the issue? That is on 1.55, but maybe it's worth a beta backport to only have a single version with the problem.

@GuillaumeGomez

GuillaumeGomez commented Sep 10, 2021

Copy link
Copy Markdown
Member

Yes it's the one.

@dns2utf8

dns2utf8 commented Sep 10, 2021

Copy link
Copy Markdown
ContributorAuthor

Unfortunately it has reached stable too: https://doc.rust-lang.org/beta/core/arch/arm/index.html

@GuillaumeGomez

GuillaumeGomez commented Sep 10, 2021

Copy link
Copy Markdown
Member

Ah damn... Oh well, at least it'll only be one version with this issue...

@dns2utf8

dns2utf8 commented Sep 10, 2021

Copy link
Copy Markdown
ContributorAuthor

If there is a 1.55.1 release we could backport the workaround there too

@dns2utf8dns2utf8 mentioned this pull request Sep 10, 2021
Merged
@ManishearthManishearth mentioned this pull request Sep 10, 2021
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 11, 2021
@bors
Auto merge ofrust-lang#88824- Manishearth:rollup-7bzk9h6, r=Manishe…
22719ef
…arth
Rollup of 15 pull requests
Successful merges:
- rust-lang#85200 (Ignore derived Clone and Debug implementations during dead code analysis)
- rust-lang#86165 (Add proc_macro::Span::{before, after}.)
- rust-lang#87088 (Fix stray notes when the source code is not available)
- rust-lang#87441 (Emit suggestion when passing byte literal to format macro)
- rust-lang#88546 (Emit proper errors when on missing closure braces)
- rust-lang#88578 (fix(rustc): suggest `items` be borrowed in `for i in items[x..]`)
- rust-lang#88632 (Fix issues with Markdown summary options)
- rust-lang#88639 (rustdoc: Fix ICE with `doc(hidden)` on tuple variant fields)
- rust-lang#88667 (Tweak `write_fmt` doc.)
- rust-lang#88720 (Rustdoc coverage fields count)
- rust-lang#88732 (RustWrapper: avoid deleted unclear attribute methods)
- rust-lang#88742 (Fix table in docblocks)
- rust-lang#88776 (Workaround blink/chromium grid layout limitation of 1000 rows)
- rust-lang#88807 (Fix typo in docs for iterators)
- rust-lang#88812 (Fix typo `option` -> `options`.)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 3aaec55 into rust-lang:masterSep 11, 2021
@rustbotrustbot added this to the 1.57.0 milestone Sep 11, 2021
@dns2utf8

dns2utf8 commented Sep 11, 2021

Copy link
Copy Markdown
ContributorAuthor

Should I open a PR with this commit on the beta branch too?

@GuillaumeGomez

GuillaumeGomez commented Sep 11, 2021

Copy link
Copy Markdown
Member

Yes please. :)

dns2utf8 added a commit to dns2utf8/rust that referenced this pull request Sep 11, 2021
@dns2utf8
Backportrust-lang#88776: Workaround blink/chromium grid layout limit…
5fb9625
…ation of 1000 rows
See rust-lang#88545 for more details
@dns2utf8dns2utf8 mentioned this pull request Sep 11, 2021
Closed
@dns2utf8

dns2utf8 commented Sep 11, 2021

Copy link
Copy Markdown
ContributorAuthor

Done :) Could you move the beta-nominated label to the new PR?

@jyn514

jyn514 commented Sep 11, 2021

Copy link
Copy Markdown
Member

This is not how beta nominations work. Please use the existing process so the release team can keep track of which PRs have been backported and which haven't.

https://forge.rust-lang.org/release/backporting.html?highlight=Beta%20n#beta-backporting-in-rust-langrust

@jyn514jyn514 added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Sep 11, 2021
@dns2utf8

dns2utf8 commented Sep 11, 2021

Copy link
Copy Markdown
ContributorAuthor

Very sorry. I renamed the other PR, but I am not sure If I should be reopened ir or if someone else will cherrypick one of the PRs or me doing nothing?

@jyn514

jyn514 commented Sep 11, 2021

Copy link
Copy Markdown
Member

@dns2utf8 it's ok, that's why there's docs :) if you want to make a backport PR that's fine, but please include all the other beta accepted PRs at the same time, and ask a member of T-release to review, not Guillaume.

@camelid

camelid commented Sep 11, 2021

Copy link
Copy Markdown
Member

It's probably best to just wait for T-release to backport this PR with the other beta backports. Someone from T-release goes through and backports beta-accepted PRs periodically.

@cuvipercuviper mentioned this pull request Sep 14, 2021
Merged
@cuvipercuviper removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Sep 14, 2021
@cuvipercuviper modified the milestones: 1.57.0, 1.56.0Sep 14, 2021
@jyn514jyn514 mentioned this pull request Sep 15, 2021
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 17, 2021
@bors
Auto merge ofrust-lang#88946- cuviper:beta-next, r=Mark-Simulacrum
deef866
[beta] backports
- rustdoc: Fix ICE with `doc(hidden)` on tuple variant fields rust-lang#88639
- Fix 2021 `dyn` suggestion that used code as label rust-lang#88657
- Workaround blink/chromium grid layout limitation of 1000 rows rust-lang#88776
- Change scope of temporaries in match guards rust-lang#88678
- Add a regression test for rust-lang#88649rust-lang#88691
- Revert anon union parsing rust-lang#88775
- Disable validate_maintainers. rust-lang#88977
Also drop stage0 rustfmt, because that's only supposed to be used on master.
r? `@Mark-Simulacrum`
Manishearth added a commit to Manishearth/rust that referenced this pull request Oct 5, 2021
@Manishearth
Rollup merge ofrust-lang#88816- dns2utf8:rustdoc_test_gui_2k_consta…
117270d
…nts, r=GuillaumeGomez
Rustdoc migrate to table so the gui can handle >2k constants
Closesrust-lang#88545.
This PR adds a test for overlapping entries in the `item-table` rust-lang#88545
It currently includes the commit with the workaround from rust-lang#88776
Manishearth added a commit to Manishearth/rust that referenced this pull request Oct 5, 2021
@Manishearth
Rollup merge ofrust-lang#88816- dns2utf8:rustdoc_test_gui_2k_consta…
52d3afa
…nts, r=GuillaumeGomez
Rustdoc migrate to table so the gui can handle >2k constants
Closesrust-lang#88545.
This PR adds a test for overlapping entries in the `item-table` rust-lang#88545
It currently includes the commit with the workaround from rust-lang#88776
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GuillaumeGomezGuillaumeGomezGuillaumeGomez approved these changes

Assignees

@GuillaumeGomezGuillaumeGomez

Labels

A-rustdoc-uiArea: Rustdoc UI (generated HTML)beta-acceptedAccepted for backporting to the compiler in the beta channel.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.56.0

Development

Successfully merging this pull request may close these issues.

9 participants

@dns2utf8@GuillaumeGomez@bors@Nemo157@jyn514@camelid@cuviper@rust-highfive@rustbot